Err(JsonMalformed("VCAP_SERVICES"))

[Heiko-Zelt]

When I call cf_env::get_services() I get a JsonMalformed-Err. I can't see anything wrong with my JSON code.

Example:

        env::set_var("VCAP_SERVICES", indoc!{r#"{
            "user-provided": [
                {
                    "binding_guid": "ba648ba7-8d10-488b-8036-911afae2042d",
                    "binding_name": "ldap1",
                    "credentials": {
                        "base_dn": "dc=de",
                        "bind_dn": "cn=admin1,dc=de",
                        "password": "secret1",
                        "url": "ldap://ldap1.provider.de:389"
                     },
                    "instance_guid": "3c1b27f2-e943-432a-a915-ff74a125091a",
                    "instance_name": "ldap100",
                    "label": "user-provided",
                    "name": "ldap1",
                    "syslog_drain_url": null,
                    "tags": [],
                    "volume_mounts": []
                }
            ]
        }"#});
        let cf_services = cf_env::get_services();
        println!("cf_services: {:?}", cf_services);

It would be helpful, if JsonMalformed would give a position, where the syntax error is found.

[Heiko-Zelt]

I compared my example and your source code and unit tests. I found out, in my cloud foundry environment there is no field "plan" but it is not Optional in your Service struct. My Java-CF-Env-Library doesn't require a "plan". I have no idea what a "plan" is, but maybe

pub struct Service<Credentials = Value> {
    ...
    pub plan: String,
    ....
}

should be changed to

pub struct Service<Credentials = Value> {
    ...
    pub plan: Option<String>,
    ....
}

?

[somehowchris]

So yes, that error might be a bit misleading, will check on what I can do to make it more transparent.

The other thing about the optional casing; the modelling of that is based on whats provided by the Cloud Foundry docs about VCAP_SERVICES and others examples like java-cfenv. All of them include a plan attribute, so the question is in what case wouldn't you get a plan attribute? There is a line where you could consider all of them optional but most of them are needed by spec

[Heiko-Zelt]

In general JSON is often used without defining a schema or verifying it. So attributes are easily omitted. My cloud environment is operated by some guys from an other department. I don't know what software version we use or if something is wrong with it. But we use it in production for many projects and it's working fine.

In had a short look into the source code of java-cfenv. It looks like the keys and values are stored in a map. This means they are all optional.

I would like to be able to install my application not just in Cloud Foundry but maybe also old fashioned on virtual servers and/or in docker/kubernetes containers. So I have to set the environment variable VCAP_SERVICES manually. Usually I need only very few attributes ("name" xor "binding_name" and "credentials"). It's more convenient to have them optional and not to provide useless configuration parameters. And in my development environment and in my unit tests I also would prefer to have my JSON code clear and brief.

For now I wrote my own get_services...() function because I needed a solution fast. It would be great to read opinions of other users about this.