This issue tracks reimplementing the work from stale PR #2843, which has been closed because it is too far out of date to merge directly.
Original pull request
What the original PR was trying to do
Description of Changes There's been no way to use product types like this: because SQL queries containing tuples: would fail with: Error: Unsupported expression: (0, 0) This PR implements tuple support for = and != operators (subject to further expansion). API and ABI breaking changes None. Expected complexity level and risk 2. Testing - [x] Manual testing using custom struct columns. - [ ] Needs unit tests. I leave this open for contributions or as an exercise to the employees.
Closure context
- I think we would like to take a design pass on the syntax, especially because this PR is using tuple syntax for product values. We'd like to evaluate Postgres and ANSI syntax for this feature. I'm going to close this PR and create a ticket to track this feature.
Reimplementation notes
- Reimplement this work on top of current
master in a new PR.
- Keep the original PR linked as historical context and as a source of useful implementation ideas where still relevant.
This issue tracks reimplementing the work from stale PR #2843, which has been closed because it is too far out of date to merge directly.
Original pull request
What the original PR was trying to do
Description of Changes There's been no way to use product types like this: because SQL queries containing tuples: would fail with: Error: Unsupported expression: (0, 0) This PR implements tuple support for = and != operators (subject to further expansion). API and ABI breaking changes None. Expected complexity level and risk 2. Testing - [x] Manual testing using custom struct columns. - [ ] Needs unit tests. I leave this open for contributions or as an exercise to the employees.
Closure context
Reimplementation notes
masterin a new PR.