revert: drop trait method aliasing#128
Open
cjmellor wants to merge 1 commit into
Open
Conversation
Reverts PR #123's private-helper indirection. The helpers were only justified by the trait-method-aliasing escape hatch, which #123 itself acknowledged was incomplete (HasTiers, Multiplier::forUser, the four listeners, and Eloquent's refresh() path all still called the public methods). Rather than chase every external call site forever, the package now treats trait method names as part of its API: hosts whose User model defines a colliding challenges() / streaks() / experience() / experienceHistory() should rename their own method or compose this package into a wrapper model. - inline challengesRelation() into challenges() (keeps #122 table config call) - inline streaksRelation() into streaks() - inline experienceRelation() / experienceHistoryRelation() back into experience() / experienceHistory() - drop loadedExperience() helper; restore $this->experience magic property and $this->load('experience') pattern that pre-#123 used - drop AliasingUser fixture, TraitAliasingTest, and the property docblock entry on TestCase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.