Bump actions/upload-artifact from 4 to 7#44
Conversation
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 7. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v7) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
requested review from
dav3r,
felddy,
jsf9k and
mcdonnnj
as code owners
github-project-automation
Bot
moved this from Review in progress
to Reviewer approved
in Skeleton Maintenance
| uses: actions/upload-artifact@v4 | ||
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: ${{ github.event.repository.name }}-${{ env.GH_SHORT_SHA }} |
There was a problem hiding this comment.
I think we'd want to leverage the new functionality in v7 to avoid double-zipping. We may need to see if the name argument should be removed.
| name: ${{ github.event.repository.name }}-${{ env.GH_SHORT_SHA }} | |
| archive: false | |
| name: ${{ github.event.repository.name }}-${{ env.GH_SHORT_SHA }} |
There was a problem hiding this comment.
They do say that the name field is ignored when archive: false is used.
There was a problem hiding this comment.
Do we want to move the artifact (with the default name) to ${{ github.event.repository.name }}-${{ env.GH_SHORT_SHA }} before uploading? Or just upload with the default name?
There was a problem hiding this comment.
Shouldn't this be a separate PR if we end up changing the current functionality?
There was a problem hiding this comment.
I'm fine with it being in a separate PR, but I still need to know what we decide in order to create the second PR.
There was a problem hiding this comment.
Since it's tied to updating the version of this dependency I think this is a fine place for it. As far as the name goes I'm fine with either choice. I think i originally picked the name I did just for convenience if downloading multiple artifacts.
There was a problem hiding this comment.
I don't have a preference on the name either. If we are keeping this in this PR, please at least mention it somewhere in the PR description.
There was a problem hiding this comment.
Please see commit 722076e and the updated PR description.
There was a problem hiding this comment.
@mcdonnnj - Please resolve this conversation if you are happy with the changes I made.
Also remove the name attribute as it is not used when archive is false. Having done that, we may as well remove the task to get the short SHA for the commit being used since the output is no longer used. Co-authored-by: Nick M <50747025+mcdonnnj@users.noreply.github.com>
3 participants
Bumps actions/upload-artifact from 4 to 7.
Release notes
Sourced from actions/upload-artifact's releases.
... (truncated)
Commits
bbbca2dSupport direct file uploads (#764)589182cUpgrade the module to ESM and bump dependencies (#762)47309c9Merge pull request #754 from actions/Link-/add-proxy-integration-tests02a8460Add proxy integration testb7c566aMerge pull request #745 from actions/upload-artifact-v6-releasee516bc8docs: correct description of Node.js 24 support in READMEddc45eddocs: update README to correct action name for Node.js 24 support615b319chore: release v6.0.0 for Node.js 24 support017748bMerge pull request #744 from actions/fix-storage-blob38d4c79chore: rebuild distDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Note that this upgrade allows us to start using the
archive: falseattribute, which avoids double-zipping the (already zipped) artifact.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)