Skip to content

Get rid of Docker warnings#31

Merged
jsf9k merged 2 commits into
developfrom
improvement/get-rid-of-docker-compose-warning
Oct 9, 2025
Merged

Get rid of Docker warnings#31
jsf9k merged 2 commits into
developfrom
improvement/get-rid-of-docker-compose-warning

Conversation

@jsf9k

@jsf9k jsf9k commented Sep 3, 2024

Copy link
Copy Markdown
Member

🗣 Description

This pull request gets rid of one warning from docker compose and two warnings from docker build.

💭 Motivation and context

  • The docker-compose warning is due to the fact that the version key has been deprecated in Docker composition files.
  • The docker warnings are both due to the fact that in Dockerfile the word AS should be uppercase in FROM...AS... lines.

Code without warnings is cleaner code.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release labels Sep 3, 2024
@jsf9k jsf9k self-assigned this Sep 3, 2024
@jsf9k jsf9k marked this pull request as ready for review September 3, 2024 13:21
@jsf9k jsf9k requested a review from a team September 3, 2024 13:21

@dav3r dav3r left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@lwersiy lwersiy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsf9k jsf9k enabled auto-merge October 9, 2025 20:08
@jsf9k jsf9k disabled auto-merge October 9, 2025 20:09
jsf9k added 2 commits October 9, 2025 16:20
This gets rid of a warning from docker-compose.
This gets rid of a warning from Docker.
@jsf9k jsf9k force-pushed the improvement/get-rid-of-docker-compose-warning branch from 8df9437 to 830fd13 Compare October 9, 2025 20:20
@github-actions github-actions Bot added the docker Pull requests that update Docker code label Oct 9, 2025
@jsf9k jsf9k added this pull request to the merge queue Oct 9, 2025
Merged via the queue into develop with commit 2b1e28f Oct 9, 2025
26 checks passed
@jsf9k jsf9k deleted the improvement/get-rid-of-docker-compose-warning branch October 9, 2025 20:35
@github-project-automation github-project-automation Bot moved this from Reviewer approved to Done in Skeleton Maintenance Oct 9, 2025
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Next Kraken Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docker Pull requests that update Docker code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants