Use the same version of Bandit throughout the pre-commit config file#30
Closed
jsf9k wants to merge 1 commit into
Closed
Use the same version of Bandit throughout the pre-commit config file#30jsf9k wants to merge 1 commit into
pre-commit config file#30jsf9k wants to merge 1 commit into
Conversation
jsf9k
force-pushed
the
bugfix/use-same-version-of-bandit
branch
from
2b72d10 to
4fa7aed
Compare
It doesn't make sense to run Bandit twice with different versions.
jsf9k
force-pushed
the
bugfix/use-same-version-of-bandit
branch
from
4fa7aed to
c8f9da0
Compare
jsf9k
added
the
kraken 🐙
dv4harr10
approved these changes
Aug 28, 2024
Member
Author
|
Closing since this is taken care of in #34. |
github-project-automation
Bot
moved this from Reviewer approved
to Done
in Skeleton Maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request updates the
pre-commitconfiguration file to use the same version of the Python packagebanditthroughout.💭 Motivation and context
It doesn't make sense to run Bandit twice with different versions.
🧪 Testing
All automated tests pass. I also verified that my Emacs code to install dependencies from
pre-commitnow functions as expected; previously, it was failing because two different versions of thebanditpackage were being requested.✅ Pre-approval checklist