From c3be1937528b083880afaa3cf8fd63174b374676 Mon Sep 17 00:00:00 2001 From: Martin Bens Date: Fri, 20 Nov 2026 12:50:36 +0100 Subject: [PATCH] test: accept readonly render output from pi 1.6.0 components pi-tui 1.6.0 changed `Component.render()` to return `readonly string[]`. The test helpers declared a mutable `string[]` return, so they no longer accepted real components and the current-pi compatibility check failed to typecheck. The helpers in `model-groups-tui.test.ts`, `render-snapshots.test.ts`, `spawn-render.test.ts` and `helpers.ts` now take `readonly string[]`, which the `string[]` returned by the pinned 1.2.0 still satisfies. --- tests/unit/helpers.ts | 4 ++-- tests/unit/model-groups-tui.test.ts | 12 ++++++------ tests/unit/render-snapshots.test.ts | 4 ++-- tests/unit/spawn-render.test.ts | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/tests/unit/helpers.ts b/tests/unit/helpers.ts index d211126d..aeb8c591 100644 --- a/tests/unit/helpers.ts +++ b/tests/unit/helpers.ts @@ -214,14 +214,14 @@ export function stripAnsi(text: string): string { return stripTerminalSequences(text); } -export function getRenderedLine(lines: string[], match: (plain: string) => boolean): string { +export function getRenderedLine(lines: readonly string[], match: (plain: string) => boolean): string { const line = lines.find((candidate) => match(stripAnsi(candidate))); assertPresent(line); expect(line).not.toBe(""); return line; } -export function getLineContaining(lines: string[], text: string): string { +export function getLineContaining(lines: readonly string[], text: string): string { const line = lines.find((candidate) => candidate.includes(text)); assertPresent(line); expect(line).not.toBe(""); diff --git a/tests/unit/model-groups-tui.test.ts b/tests/unit/model-groups-tui.test.ts index 382c207a..b94d8232 100644 --- a/tests/unit/model-groups-tui.test.ts +++ b/tests/unit/model-groups-tui.test.ts @@ -137,7 +137,7 @@ const LEFT = "\u001b[D"; const BACKSPACE = "\u007f"; const LEFT_SS3 = "\u001bOD"; -function press(c: { handleInput?: (data: string) => void; render?: (width: number) => string[] }, ...inputs: string[]): void { +function press(c: { handleInput?: (data: string) => void; render?: (width: number) => readonly string[] }, ...inputs: string[]): void { for (const input of inputs) { c.render?.(100); c.handleInput?.(input); @@ -153,23 +153,23 @@ if (FAKE_CURSOR_PARTS.length !== 2 || FAKE_CURSOR_PARTS[0] === "") { } const FAKE_CURSOR_START = FAKE_CURSOR_PARTS[0]; -function rendered(c: { render: (width: number) => string[] }, width = 100): string { +function rendered(c: { render: (width: number) => readonly string[] }, width = 100): string { return c.render(width).join("\n"); } -function findSelectedRow(c: { render: (width: number) => string[] }): string | undefined { +function findSelectedRow(c: { render: (width: number) => readonly string[] }): string | undefined { return stripAnsi(rendered(c)) .split("\n") .find((line) => line.includes("→")); } -function selectedRow(c: { render: (width: number) => string[] }): string { +function selectedRow(c: { render: (width: number) => readonly string[] }): string { const row = findSelectedRow(c); assertPresent(row, "the rendered screen has a selected row marked →"); return row; } -function selectRenderedLabel(c: { handleInput?: (data: string) => void; render: (width: number) => string[] }, label: string): void { +function selectRenderedLabel(c: { handleInput?: (data: string) => void; render: (width: number) => readonly string[] }, label: string): void { for (let i = 0; i < 32; i++) { // A screen without a selected row is not this label yet: keep pressing DOWN. if (findSelectedRow(c)?.includes(label) === true) { @@ -192,7 +192,7 @@ function openAddModelWizard(c: Parameters[0]): void press(c, ENTER); // EDITOR → WIZARD_PROVIDER } -function pressAndRender(c: { handleInput?: (data: string) => void; render: (width: number) => string[] }, ...inputs: string[]): void { +function pressAndRender(c: { handleInput?: (data: string) => void; render: (width: number) => readonly string[] }, ...inputs: string[]): void { for (const input of inputs) { c.render(100); c.handleInput?.(input); diff --git a/tests/unit/render-snapshots.test.ts b/tests/unit/render-snapshots.test.ts index c93e5604..11e82646 100644 --- a/tests/unit/render-snapshots.test.ts +++ b/tests/unit/render-snapshots.test.ts @@ -26,8 +26,8 @@ const SNAPSHOT_DIR = join(__dirname, "..", "snapshots"); // ── Render test backend ─────────────────────────────────────────────── class RenderTestBackend { - lines: string[] = []; - render(component: { render(w: number): string[] }, width = 80): this { + lines: readonly string[] = []; + render(component: { render(w: number): readonly string[] }, width = 80): this { this.lines = component.render(width); return this; } diff --git a/tests/unit/spawn-render.test.ts b/tests/unit/spawn-render.test.ts index eacdf4ad..53a9cba6 100644 --- a/tests/unit/spawn-render.test.ts +++ b/tests/unit/spawn-render.test.ts @@ -184,7 +184,7 @@ test("collapsed nested spawn render keeps all text blocks from the last assistan expect(lines).toContainEqual(expect.stringContaining("second")); }); -async function renderCollapsedPreview(text: string, width: number): Promise { +async function renderCollapsedPreview(text: string, width: number): Promise { const state = createState(); const childSpawnTool = await makeChildSpawnTool(state); state.childSessions.set("tool-call-1", createSession([{ role: "assistant", content: [{ type: "text", text }] }]));