From 971f7475d8b27f309a70ef692a480db01964f90c Mon Sep 17 00:00:00 2001 From: Martin Bens Date: Tue, 17 Nov 2026 20:28:49 +0100 Subject: [PATCH 1/2] ci: allowlist the picomatch ReDoS advisory in the dev tooling GHSA-fc5q-39xc-vjpf (CVE-2026-112366) was GitHub-reviewed on 2026-11-17, so npm audit started reporting it and audit-ci failed the job on every branch. It covers every picomatch release up to 4.0.7, which is the latest, so no upgrade fixes it. picomatch reaches the tree only through knip, vite, vitest and tinyglobby in the lint, test and dead-code tooling, and compiles globs from repository config, never untrusted input. The entry expires on 2027-01-31 so the audit checks again for a patched release. --- audit-ci.jsonc | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/audit-ci.jsonc b/audit-ci.jsonc index 654ff435..e341efa4 100644 --- a/audit-ci.jsonc +++ b/audit-ci.jsonc @@ -64,6 +64,13 @@ "notes": "undici: DoS via TLS 1.2 certificate-changing renegotiation. npm audit affected range: >=8.0.0 <8.12.2. Installed 8.10.2 under @earendil-works/pi-coding-agent@1.2.0 (npm ls). Transitive in the pinned test host @earendil-works/pi-coding-agent@1.2.0 (devDependency).", "expiry": "2026-12-31" } + }, + { + "GHSA-fc5q-39xc-vjpf": { + "active": true, + "notes": "picomatch: ReDoS through single-branch repeated extglobs (CVE-2026-112366). npm audit affected range: <=4.0.7, no patched release. Installed 4.0.7 as one deduped copy, required by knip@6.45.1, vite@8.3.7, vitest@5.1.0 and tinyglobby@0.2.17 under eslint-import-resolver-typescript@4.4.5 and typescript-eslint (npm ls). Transitive in the lint, test and dead-code tooling (devDependencies) only; the globs it compiles come from repository config, not untrusted input.", + "expiry": "2027-01-31" + } } ] } From 9bdb1a62b0b44c54661c920e13c0be36f674311b Mon Sep 17 00:00:00 2001 From: Martin Bens Date: Tue, 17 Nov 2026 20:32:17 +0100 Subject: [PATCH 2/2] test: expect the picomatch advisory in the audit allowlist EXPECTED_ALLOWLIST_KEYS pins the exact set of audit-ci allowlist entries, so adding GHSA-fc5q-39xc-vjpf to audit-ci.jsonc failed the config invariants test until the set listed it too. --- tests/unit/config-invariants.test.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/unit/config-invariants.test.ts b/tests/unit/config-invariants.test.ts index 41cdb49f..1a9327af 100644 --- a/tests/unit/config-invariants.test.ts +++ b/tests/unit/config-invariants.test.ts @@ -51,8 +51,9 @@ const EXPECTED_TYPEBOX_VERSION = "1.3.27"; const EXPECTED_PI_PEER = `>=${EXPECTED_PI_VERSION}`; const EXPECTED_TYPEBOX_PEER = `>=${EXPECTED_TYPEBOX_VERSION}`; // Transitive undici and minimatch advisories in the pinned test host -// @earendil-works/pi-coding-agent@1.2.0 (devDependency). Remove an entry when a -// pinned host ships a patched version; the expiry forces periodic re-review. +// @earendil-works/pi-coding-agent@1.2.0 (devDependency), and the picomatch advisory +// in the lint, test and dead-code tooling. Remove an entry when a patched version +// is installed; the expiry forces periodic re-review. const EXPECTED_ALLOWLIST_KEYS = new Set([ "GHSA-xjj6-f33q-929c", "GHSA-4qv8-2p9j-2685", @@ -63,6 +64,7 @@ const EXPECTED_ALLOWLIST_KEYS = new Set([ "GHSA-9fm3-97px-rjf6", "GHSA-55wc-3pg8-jfw6", "GHSA-g3hv-75wg-m249", + "GHSA-fc5q-39xc-vjpf", ]); function readText(url: URL): string {