Validate TestFlight packaging and App Store icon separately

[cbusillo]

Objective

Keep TestFlight packaging/icon validation separate from runtime/provider bugs so App Store Connect issues do not blur with local dogfood behavior.

Finish Line

The archive/upload path includes the expected app icon assets, entitlements, embedded provisioning profiles, and bundle metadata, and any App Store Connect icon issue has package/archive evidence.

Current Status

State: Active
Next action: After runtime/provider stabilization, inspect the generated archive/pkg/zip upload artifact rather than the running app bundle alone.
Blocked by: Runtime recovery and dirty-tree triage.
Last verified: 2026-05-12 installed app contained AppIcon.icns, Assets.car, and CFBundleIconName=AppIcon, but ASC behavior still needed upload-path inspection.

Scope

• In: TestFlight packaging, icon asset inclusion, Info.plist icon metadata, provisioning profiles, entitlements, upload validation.
• Out: Provider runtime failures and settings UI regressions.

Acceptance Criteria

• Upload artifact contains expected icon resources and Info.plist keys.
• App, widget, and refresh agent profiles/entitlements match App Store requirements.
• TestFlight upload validation is run only from a coherent release branch/build.
• App Store Connect icon finding, if still present, has artifact-level evidence.

Relationships

Sub-issue of #64.

Validation

Inspect the generated upload artifact, not just /Applications, and run the configured TestFlight packaging/upload validation path.

Decisions

Installed app icon presence is necessary but not sufficient evidence for ASC.

Open Questions

Is ASC missing the icon because of the archive/pkg/upload path, asset catalog compilation, or metadata processing delay?

[cbusillo]

TestFlight export validation is blocked before archive creation.\n\nEvidence:\n- Branch: release/testflight-packaging-validation\n- Head SHA: 5fb3fbf\n- Workflow: TestFlight export-only, upload=false, build_number=2026051501\n- Run: https://github.com/cbusillo/context-panel/actions/runs/25943318319\n- Failure: scripts/upload-testflight-macos-app.sh decoded the CI app provisioning profile and failed because it is missing MM5YXC7T6E.group.com.shinycomputers.contextpanel.\n\nThis means the upload artifact could not be produced yet, so icon/pkg inspection remains pending. Next blocker to clear is replacing/regenerating the MACOS_APP_STORE_APP_PROVISIONING_PROFILE_BASE64 secret with an App Store profile for com.shinycomputers.contextpanel that includes the canonical app group entitlement. Widget and refresh-agent profiles still need validation after this app-profile blocker is cleared.

[cbusillo]

TestFlight export-only validation passed after fixing two packaging-script assumptions on branch release/testflight-packaging-validation.\n\nEvidence:\n- Workflow run: https://github.com/cbusillo/context-panel/actions/runs/25943608314\n- Branch/SHA: release/testflight-packaging-validation @ af51464\n- Inputs: version=1.0, build_number=2026051503, upload=false\n- Artifact: testflight-export-2026051503, containing Context Panel.pkg plus export plists/logs\n\nArtifact inspection:\n- Expanded pkg contains Context Panel.app, ContextPanelWidgetExtension.appex, and ContextPanelRefreshAgent.app.\n- App Info.plist has bundle id com.shinycomputers.contextpanel, CFBundleIconName=AppIcon, CFBundleIconFile=AppIcon, version=1.0, build=2026051503.\n- App package contains Contents/Resources/AppIcon.icns and Contents/Resources/Assets.car.\n- Widget bundle id is com.shinycomputers.contextpanel.widget.\n- Refresh agent bundle id is com.shinycomputers.contextpanel.refresh-agent.\n- App/widget/refresh-agent all include embedded provisioning profiles.\n- Embedded profile app IDs match MM5YXC7T6E.com.shinycomputers.contextpanel, MM5YXC7T6E.com.shinycomputers.contextpanel.widget, and MM5YXC7T6E.com.shinycomputers.contextpanel.refresh-agent.\n- Profile app-group authorization appears as group.com.shinycomputers.contextpanel plus MM5YXC7T6E.*; signed entitlements use MM5YXC7T6E.group.com.shinycomputers.contextpanel.\n- codesign --verify --deep --strict passed for app; codesign --verify --strict passed for widget and refresh agent.\n- Signed entitlements match expected shape: app and refresh agent include sandbox, app group, network client, app-scope bookmarks, and provider credential keychain group; widget includes sandbox and app group only.\n\nFixes made on the branch:\n- Accept same-team app-group wildcard authorization in provisioning profiles while still requiring exact bundle app IDs.\n- Use the installed App Store installer identity label, 3rd Party Mac Developer Installer, for export.

[cbusillo]

Closed by PR #83. TestFlight export-only workflow passed and the exported pkg was inspected for icon resources, Info.plist icon metadata, embedded profiles, signed entitlements, and app/widget/refresh-agent bundle structure. Artifact evidence is in the prior comment.