cncli sign does not emit anymore the proof but only its hash

[safanaj]

Describe the bug
I am not really sure if this is a bug or my misinterpretation, but I noticed a changes in the cncli sign command about that is put in output, and apparently it does not print anymore the proof but its hash.

previously it was putting the 80 bytes of the proof encoded as hex, not it prints 64 bytes of the hash,
I do not understand how that signature hash could be for example being used by cncli verify.

[safanaj]

I also noticed that the cncli verify command is checking the vrf vkey hash with 224 bits, but as I see using:
cardano-cli node key-hash-VRF the hash is 256 bits, and also using query pool-params as suggested in the outdated UASGE.md like:

cardano-cli query pool-params  --mainnet --stake-pool-id 040d79b06f8ad1a94bd8fbc9eac9ba8ccf44a332d9d7f003d85f9393| jq 'to_entries|first|.value.poolParams.vrf' -r

the hash still 256 bits.

Below I put a bad patch that basically "bypasses" the vrf prove implementation of the amaru_ouroborus::vrf and just use the dalek one directly to get the signature bytes to hash. Of course this is not the way, just to explain what I mean with the issue as I do not have any knowledge of rust.

+++ b/src/nodeclient/sign/mod.rs
@@ -1,4 +1,5 @@
 use amaru_ouroboros::vrf::{Input, Proof, PublicKey, SecretKey};
+use vrf_dalek::vrf03::{VrfProof03, SecretKey03, PublicKey03};
 use pallas_crypto::hash::{Hash, Hasher};
 use rand::{rng, Rng};
 use serde::Serialize;
@@ -29,6 +30,7 @@ struct ChallengeSuccess {
 struct SignSuccess {
     status: String,
     signature: String,
+    signature_hash: String,
 }
 
 #[derive(Debug, Serialize)]
@@ -76,20 +78,27 @@ pub(crate) fn sign_challenge(pool_vrf_skey: &Path, domain: &str, nonce: &str) {
                         return;
                     }
 
-                    let vrf_skey: &[u8; SecretKey::SIZE] = vrf_skey.key[0..SecretKey::SIZE]
+                    let vrf_skey_bytes: &[u8; SecretKey::SIZE] = vrf_skey.key[0..SecretKey::SIZE]
                         .try_into()
                         .expect("Invalid VRF signing key length");
-                    let vrf_skey = SecretKey::from(vrf_skey);
+                    let vrf_skey = SecretKey::from(vrf_skey_bytes);
+                    let vrf_skey03 = SecretKey03::from_bytes(vrf_skey_bytes);
+                   // let vrf_vkey03 = PublicKey03::from(&vrf_skey03);
                     let vrf_challenge_input: Input =
                         Input::try_from(challenge_bytes.as_ref()).expect("Failed to convert challenge bytes to Input");
                     let vrf_proof = vrf_skey.prove(&vrf_challenge_input);
-                    let signature: Hash<{ Proof::HASH_SIZE }> = Hash::from(&vrf_proof);
+                    let vrf_proof03 = VrfProof03::generate(&PublicKey03::from(&vrf_skey03), &vrf_skey03, vrf_challenge_input.as_ref());
+                    let signature_hash: Hash<{ Proof::HASH_SIZE }> = Hash::from(&vrf_proof);
+                    let signature = vrf_proof03.to_bytes();
+
                     debug!("signature: {}", hex::encode(signature));
+                    debug!("signature_hash: {}", hex::encode(signature_hash));
                     serde_json::ser::to_writer_pretty(
                         &mut stdout(),
                         &SignSuccess {
                             status: "ok".to_string(),
                             signature: hex::encode(signature),
+                            signature_hash: hex::encode(signature_hash),
                         },
                     )
                     .unwrap();
@@ -120,7 +129,7 @@ pub(crate) fn verify_challenge(
                         return;
                     }
                     // Verify that the vkey the client supplied is the same as the one on-chain
-                    let vkey_hash_verify = hex::encode(Hasher::<224>::hash(&vrf_vkey.key[0..SecretKey::SIZE]));
+                    let vkey_hash_verify = hex::encode(Hasher::<256>::hash(&vrf_vkey.key[0..SecretKey::SIZE]));
                     debug!("vkey_hash_verify: {}", &vkey_hash_verify);
 
                     if pool_vrf_vkey_hash != vkey_hash_verify {