From d719df36f1cacca881d91f4abe616a3b97e1b7f4 Mon Sep 17 00:00:00 2001
From: bjyn <bjyn@example.com>
Date: Thu, 20 Aug 2026 13:39:37 +0100
Subject: [PATCH] fix: prevent race condition causing 'Already compacted' error

- Add guard in triggerAutoCompact to check pendingCompaction and last entry type
- Re-check pendingCompaction in context event handler's setImmediate callback
- Prevents duplicate compaction calls from racing and throwing 'Already compacted'
---
 extensions/auto-compact.ts | 23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/extensions/auto-compact.ts b/extensions/auto-compact.ts
index cde0696..72ffadf 100644
--- a/extensions/auto-compact.ts
+++ b/extensions/auto-compact.ts
@@ -276,6 +276,14 @@ export default function autoCompact(pi: ExtensionAPI) {
     phase: AutoCompactPhase,
     customInstructions?: string,
   ): void => {
+    // Guard: if compaction is already in progress, don't start another.
+    // This prevents races from callers that don't check pendingCompaction.
+    if (pendingCompaction) return;
+    // Guard: if the last session entry is already a compaction, pi core will
+    // throw "Already compacted". Skip to avoid the error.
+    const entries = ctx.sessionManager.getEntries();
+    const lastEntry = entries[entries.length - 1];
+    if (lastEntry?.type === "compaction") return;
     pendingCompaction = true;
     ctx.compact({
       customInstructions,
@@ -382,11 +390,16 @@ export default function autoCompact(pi: ExtensionAPI) {
       if (newMessages) {
         truncationAppliedThisTurn = true;
         setImmediate(() => {
-          triggerAutoCompact(
-            ctx,
-            "emergency",
-            "Emergency context truncation was applied. Generate a comprehensive summary.",
-          );
+          // Re-check pendingCompaction: another event may have triggered compaction
+          // while this callback was deferred. Without this check, we race and get
+          // "Already compacted" from pi core.
+          if (!pendingCompaction) {
+            triggerAutoCompact(
+              ctx,
+              "emergency",
+              "Emergency context truncation was applied. Generate a comprehensive summary.",
+            );
+          }
         });
         return { messages: newMessages };
       }