diff --git a/scripts/validate_generated_pr_policy.py b/scripts/validate_generated_pr_policy.py index 57193c77e..e1b03ad70 100644 --- a/scripts/validate_generated_pr_policy.py +++ b/scripts/validate_generated_pr_policy.py @@ -14,7 +14,7 @@ REPO_ROOT = Path(__file__).resolve().parents[1] -EXPECTED_AUTHOR = "app/github-actions" +EXPECTED_AUTHOR = "app/cf-docs-generated-docs-merger" @dataclass(frozen=True) diff --git a/tests/test_update_generated_reference_prs.py b/tests/test_update_generated_reference_prs.py index 01baae3f9..818494e2f 100644 --- a/tests/test_update_generated_reference_prs.py +++ b/tests/test_update_generated_reference_prs.py @@ -1065,7 +1065,7 @@ def test_generated_pr_policy_accepts_configured_generated_paths() -> None: head_sha="abc123", ), pr_metadata={ - "author": {"login": "app/github-actions"}, + "author": {"login": "app/cf-docs-generated-docs-merger"}, "state": "OPEN", "isDraft": False, "baseRefName": "main", @@ -1115,8 +1115,38 @@ def test_generated_pr_policy_rejects_unexpected_author_and_paths() -> None: }, ) - assert "expected PR author 'app/github-actions', found 'danielporterda'" in errors + assert "expected PR author 'app/cf-docs-generated-docs-merger', found 'danielporterda'" in errors assert ( "changed files outside configured generated paths: .github/workflows/update-version-dashboard.yml" in errors ) + + +def test_generated_pr_policy_rejects_legacy_github_actions_author() -> None: + policy = load_policy_module() + + errors = policy.validate_policy( + policy_input=policy.PolicyInput( + pr_number="932", + repository="canton-network/cf-docs", + base_branch="main", + head_branch="version-dashboard/update", + head_sha="abc123", + ), + pr_metadata={ + "author": {"login": "app/github-actions"}, + "state": "OPEN", + "isDraft": False, + "baseRefName": "main", + "headRefName": "version-dashboard/update", + "headRefOid": "abc123", + }, + changed_files=("config/repo-version-config.json",), + branch_paths={ + "version-dashboard/update": ("config/repo-version-config.json",), + }, + ) + + assert errors == [ + "expected PR author 'app/cf-docs-generated-docs-merger', found 'app/github-actions'" + ]