From 455b7c4b9753477ca71db86179995c804aea1ad4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Pierzcha=C5=82a?= Date: Wed, 11 Nov 2026 12:06:07 +0100 Subject: [PATCH 1/2] fix: evaluate final AWS readiness observation --- .../src/aws-device-farm.test.ts | 58 +++++++++++++++++++ .../provider-webdriver/src/aws-device-farm.ts | 3 +- 2 files changed, 60 insertions(+), 1 deletion(-) diff --git a/packages/provider-webdriver/src/aws-device-farm.test.ts b/packages/provider-webdriver/src/aws-device-farm.test.ts index 7c3bfda634..7bcadbd2e3 100644 --- a/packages/provider-webdriver/src/aws-device-farm.test.ts +++ b/packages/provider-webdriver/src/aws-device-farm.test.ts @@ -113,6 +113,64 @@ test('the allocation deadline lets startup run past the standalone 120s default' assert.deepEqual(client.stopped, []); }); +test.each(['RUNNING', 'ERRORED', 'PENDING'] as const)( + 'decides the final %s observation at the deadline', + async (status) => { + let now = 1_000; + vi.spyOn(Date, 'now').mockImplementation(() => now); + let polls = 0; + const client = fakeClient({ status }, () => { + polls += 1; + now = 2_000; + }); + client.session.endpoints = { appium: 'https://appium.example/wd/hub' }; + const prepare = createAwsDeviceFarmPrepareSession({ + ...baseOptions(client), + startupTimeoutMs: 1_000, + }); + const result = prepare({ lease: makeLease(), base: baseSession() }); + if (status === 'RUNNING') { + assert.equal((await result).providerSessionId, ARN); + assert.deepEqual(client.stopped, []); + } else { + await assert.rejects(result, (error: unknown) => { + assert.ok(error instanceof AppError); + assert.equal(error.details?.status, status); + assert.equal(error.message.includes('did not start'), status === 'ERRORED'); + return true; + }); + assert.deepEqual(client.stopped, [ARN]); + } + assert.equal(polls, 1); + }, +); + +test('cancellation takes priority over a final RUNNING observation', async () => { + let now = 1_000; + vi.spyOn(Date, 'now').mockImplementation(() => now); + const controller = new AbortController(); + const client = fakeClient({ status: 'RUNNING' }, () => { + now = 2_000; + controller.abort(createRequestCanceledError()); + }); + const prepare = createAwsDeviceFarmPrepareSession({ + ...baseOptions(client), + startupTimeoutMs: 1_000, + }); + await assert.rejects( + prepare({ lease: makeLease(), req: { signal: controller.signal }, base: baseSession() }), + isRequestCanceledError, + ); + assert.deepEqual(client.stopped, [ARN]); +}); + +test('a running session without an endpoint is stopped', async () => { + const client = fakeClient({ status: 'RUNNING' }); + const prepare = createAwsDeviceFarmPrepareSession(baseOptions(client)); + await assert.rejects(prepare({ lease: makeLease(), base: baseSession() }), AppError); + assert.deepEqual(client.stopped, [ARN]); +}); + test('a session that reaches RUNNING is handed on and not stopped', async () => { const client = fakeClient({ status: 'RUNNING', diff --git a/packages/provider-webdriver/src/aws-device-farm.ts b/packages/provider-webdriver/src/aws-device-farm.ts index 802265db85..1f649c1745 100644 --- a/packages/provider-webdriver/src/aws-device-farm.ts +++ b/packages/provider-webdriver/src/aws-device-farm.ts @@ -289,10 +289,11 @@ async function waitForRunningRemoteAccessSession( const deadline = req?.deadline ?? startedAt + (options.startupTimeoutMs ?? 120_000); const signal = req?.signal; let last = await options.client.getRemoteAccessSession(arn); - while (Date.now() < deadline) { + while (true) { signal?.throwIfAborted(); if (last.status === 'RUNNING') return last; throwIfRemoteAccessSessionEnded(last); + if (Date.now() >= deadline) break; // Wake early on cancellation; the typed reason is rethrown at the loop top. await sleep(pollIntervalMs, undefined, { signal }).catch(() => signal?.throwIfAborted()); last = await options.client.getRemoteAccessSession(arn); From 6f6ddff30fa4a07751e4397d29bfbf8b27117ddd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Pierzcha=C5=82a?= Date: Wed, 11 Nov 2026 12:08:52 +0100 Subject: [PATCH 2/2] test(aws): exercise the final readiness retry --- .../provider-webdriver/src/aws-device-farm.test.ts | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/packages/provider-webdriver/src/aws-device-farm.test.ts b/packages/provider-webdriver/src/aws-device-farm.test.ts index 7bcadbd2e3..0b80b9cd69 100644 --- a/packages/provider-webdriver/src/aws-device-farm.test.ts +++ b/packages/provider-webdriver/src/aws-device-farm.test.ts @@ -119,14 +119,18 @@ test.each(['RUNNING', 'ERRORED', 'PENDING'] as const)( let now = 1_000; vi.spyOn(Date, 'now').mockImplementation(() => now); let polls = 0; - const client = fakeClient({ status }, () => { + const client = fakeClient({ status: 'PENDING' }, () => { polls += 1; - now = 2_000; + if (polls === 2) { + now = 2_000; + client.session.status = status; + } }); client.session.endpoints = { appium: 'https://appium.example/wd/hub' }; const prepare = createAwsDeviceFarmPrepareSession({ ...baseOptions(client), startupTimeoutMs: 1_000, + pollIntervalMs: 1, }); const result = prepare({ lease: makeLease(), base: baseSession() }); if (status === 'RUNNING') { @@ -136,12 +140,12 @@ test.each(['RUNNING', 'ERRORED', 'PENDING'] as const)( await assert.rejects(result, (error: unknown) => { assert.ok(error instanceof AppError); assert.equal(error.details?.status, status); - assert.equal(error.message.includes('did not start'), status === 'ERRORED'); + assert.equal(error.details?.timeoutMs, status === 'PENDING' ? 1_000 : undefined); return true; }); assert.deepEqual(client.stopped, [ARN]); } - assert.equal(polls, 1); + assert.equal(polls, 2); }, );