From bb78c9e4d6dc48c52e8f99d457b93ccc8b524736 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Pierzcha=C5=82a?= Date: Tue, 10 Nov 2026 22:18:34 +0100 Subject: [PATCH 1/2] fix(capture-kit): enforce network merge entry limit --- .../capture-kit/src/network-traffic.test.ts | 46 +++++++++++++++++++ packages/capture-kit/src/network-traffic.ts | 4 +- 2 files changed, 48 insertions(+), 2 deletions(-) diff --git a/packages/capture-kit/src/network-traffic.test.ts b/packages/capture-kit/src/network-traffic.test.ts index 48e9cc93db..e61bd7081f 100644 --- a/packages/capture-kit/src/network-traffic.test.ts +++ b/packages/capture-kit/src/network-traffic.test.ts @@ -75,6 +75,52 @@ test('keeps missing canonical app-log text distinct and merges recovery first', ); }); +test('bounds merged network scans while preserving primary entries', () => { + const scan = (urls: string[], path: string) => + readRecentNetworkTrafficFromText( + [...urls] + .reverse() + .map((url) => `GET ${url} status=200`) + .join('\n'), + { + path, + exists: urls.length > 0, + backend: 'android', + maxEntries: 2, + include: 'summary', + maxPayloadChars: 2048, + maxScanLines: 100, + }, + ); + const urls = (value: ReturnType) => value.dump.entries.map(({ url }) => url); + const primary = scan(['https://a.example.test', 'https://b.example.test'], 'primary'); + const secondary = scan(['https://c.example.test', 'https://d.example.test'], 'secondary'); + const primaryBefore = urls(primary); + + assert.deepEqual(urls(mergeNetworkScans(primary, secondary, 2)), [ + 'https://a.example.test', + 'https://b.example.test', + ]); + assert.deepEqual(urls(primary), primaryBefore); + assert.deepEqual( + urls( + scan(['https://a.example.test', 'https://b.example.test', 'https://c.example.test'], 'large'), + ), + ['https://a.example.test', 'https://b.example.test'], + ); + assert.deepEqual( + urls( + mergeNetworkScans( + scan(['https://a.example.test'], 'one'), + scan(['https://a.example.test', 'https://b.example.test'], 'duplicate'), + 2, + ), + ), + ['https://a.example.test', 'https://b.example.test'], + ); + assert.deepEqual(urls(mergeNetworkScans(scan([], 'empty-a'), scan([], 'empty-b'), 2)), []); +}); + test('keeps Android adjacent enrichment disabled for Apple backends', () => { const { dump } = readRecentNetworkTrafficFromText( [ diff --git a/packages/capture-kit/src/network-traffic.ts b/packages/capture-kit/src/network-traffic.ts index 197b7a156d..64c8174e6c 100644 --- a/packages/capture-kit/src/network-traffic.ts +++ b/packages/capture-kit/src/network-traffic.ts @@ -61,14 +61,14 @@ export function mergeNetworkScans( secondary: NetworkScan, maxEntries = primary.dump.limits.maxEntries, ): NetworkScan { - const entries = [...primary.dump.entries]; + const entries = primary.dump.entries.slice(0, maxEntries); const seen = new Set(entries.map(networkEntryKey)); for (const entry of secondary.dump.entries) { + if (entries.length >= maxEntries) break; const key = networkEntryKey(entry); if (seen.has(key)) continue; seen.add(key); entries.push(entry); - if (entries.length >= maxEntries) break; } // The two windows can cover different, overlapping, or disjoint traffic. A // request either window named is named, and the rest union by identity, so From 95352b2058594fee78f2f540d14c0cb5786a9585 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Pierzcha=C5=82a?= Date: Tue, 10 Nov 2026 22:33:19 +0100 Subject: [PATCH 2/2] test(capture-kit): exercise trimming at the merge boundary --- packages/capture-kit/src/network-traffic.test.ts | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/packages/capture-kit/src/network-traffic.test.ts b/packages/capture-kit/src/network-traffic.test.ts index e61bd7081f..b3f5a3c116 100644 --- a/packages/capture-kit/src/network-traffic.test.ts +++ b/packages/capture-kit/src/network-traffic.test.ts @@ -102,12 +102,7 @@ test('bounds merged network scans while preserving primary entries', () => { 'https://b.example.test', ]); assert.deepEqual(urls(primary), primaryBefore); - assert.deepEqual( - urls( - scan(['https://a.example.test', 'https://b.example.test', 'https://c.example.test'], 'large'), - ), - ['https://a.example.test', 'https://b.example.test'], - ); + assert.deepEqual(urls(mergeNetworkScans(primary, secondary, 1)), ['https://a.example.test']); assert.deepEqual( urls( mergeNetworkScans(