Description
resolve_and_validate in crates/zeph-tools/src/scrape.rs (~lines 1140–1147) has the same span-after-await pattern as #4712. The tracing span is created before an async operation but entered after the .await completes, so the span covers only the synchronous result-checking code rather than the actual async work.
Spotted during the code review of PR #4730 (which fixed #4712 in apply_ipi_filter).
Fix Direction
Apply #[tracing::instrument] on resolve_and_validate, consistent with the fix applied to apply_ipi_filter in PR #4730. Remove the manual span.enter().
Environment
- HEAD: 77ed84b
- File:
crates/zeph-tools/src/scrape.rs ~lines 1140–1147
Related
Description
resolve_and_validateincrates/zeph-tools/src/scrape.rs(~lines 1140–1147) has the same span-after-await pattern as #4712. The tracing span is created before an async operation but entered after the.awaitcompletes, so the span covers only the synchronous result-checking code rather than the actual async work.Spotted during the code review of PR #4730 (which fixed #4712 in
apply_ipi_filter).Fix Direction
Apply
#[tracing::instrument]onresolve_and_validate, consistent with the fix applied toapply_ipi_filterin PR #4730. Remove the manualspan.enter().Environment
crates/zeph-tools/src/scrape.rs~lines 1140–1147Related
apply_ipi_filter, fixed in PR fix(tools): redact URLs in scrape audit log and fix IPI tracing span #4730