From a5397b8619f702c26cfa05f768c8c0db60a88f0a Mon Sep 17 00:00:00 2001 From: Nathan Ahn Date: Wed, 28 Oct 2026 14:01:14 -0400 Subject: [PATCH 1/5] v0.9.3 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 40a4f1a..0347f5d 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "react-native-app-clip", - "version": "0.9.2", + "version": "0.9.3", "packageManager": "bun@1.4.3", "description": "Config plugin to add an App Clip to a React Native iOS app", "main": "build/index.js", From b2787d3a37504ac2348ff1b0702b15dc92bbac18 Mon Sep 17 00:00:00 2001 From: Nathan Ahn Date: Mon, 9 Nov 2026 16:59:52 -0500 Subject: [PATCH 2/5] Fixing Expo 58 issue --- .github/workflows/ci.yml | 2 ++ plugin/src/withPlist.ts | 14 ++++++++++---- plugin/src/withXcode.ts | 8 ++++++-- plugin/src/xcode/addBuildPhases.ts | 6 +++--- plugin/src/xcode/addPbxGroup.ts | 18 +++++++++++++----- 5 files changed, 34 insertions(+), 14 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 031c12d..b110bed 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,6 +23,8 @@ jobs: uses: oven-sh/setup-bun@v2 - name: Install dependencies run: bun install --frozen-lockfile + - name: Test config plugin + run: bun run test plugin --watch=false --runInBand - name: Build and pack package run: | mkdir -p "$RUNNER_TEMP/npm-package" diff --git a/plugin/src/withPlist.ts b/plugin/src/withPlist.ts index 206d21c..2f68b0b 100644 --- a/plugin/src/withPlist.ts +++ b/plugin/src/withPlist.ts @@ -12,9 +12,7 @@ import { getAppClipIcon } from "./lib/getAppClipIcon"; /** * List of keys that are not allowed in the Info.plist due to not being supported in App Clip. Add to this array as new build issues arise. */ -const DisallowedPlistKeys = [ - "UIBackgroundModes", -]; +const DisallowedPlistKeys = ["UIBackgroundModes"]; export const withPlist: ConfigPlugin<{ targetName: string; @@ -67,9 +65,17 @@ export const withPlist: ConfigPlugin<{ MinimumOSVersion: deploymentTarget, }; + if (config.modResults.UIApplicationSceneManifest) { + infoPlist.UIApplicationSceneManifest = + config.modResults.UIApplicationSceneManifest; + } + if (config.ios?.infoPlist) { for (const key of Object.keys(config.ios?.infoPlist)) { - if (config.ios?.infoPlist && !DisallowedPlistKeys.some((disallowedKey) => disallowedKey === key)) { + if ( + config.ios?.infoPlist && + !DisallowedPlistKeys.some((disallowedKey) => disallowedKey === key) + ) { infoPlist[key] = config.ios.infoPlist[key]; } } diff --git a/plugin/src/withXcode.ts b/plugin/src/withXcode.ts index 7ef984f..1bde10e 100644 --- a/plugin/src/withXcode.ts +++ b/plugin/src/withXcode.ts @@ -22,7 +22,10 @@ export const withXcode: ConfigPlugin<{ bundleIdentifier: string; deploymentTarget: string; enableCompression?: boolean; -}> = (config, { name, targetName, bundleIdentifier, deploymentTarget, enableCompression }) => { +}> = ( + config, + { name, targetName, bundleIdentifier, deploymentTarget, enableCompression }, +) => { return withXcodeProject(config, (config) => { const xcodeProject = config.modResults; const appClipIcon = getAppClipIcon(config); @@ -57,7 +60,7 @@ export const withXcode: ConfigPlugin<{ addTargetDependency(xcodeProject, target); - addPbxGroup(xcodeProject, { + const sourceFiles = addPbxGroup(xcodeProject, { projectName: projectName as string, targetName, platformProjectRoot, @@ -83,6 +86,7 @@ export const withXcode: ConfigPlugin<{ productFile, enableCompression, resourcesPhaseName: appClipIcon ? "Resources" : undefined, + sourceFiles, }); if (appClipIcon) { diff --git a/plugin/src/xcode/addBuildPhases.ts b/plugin/src/xcode/addBuildPhases.ts index e9038b7..65e00d6 100644 --- a/plugin/src/xcode/addBuildPhases.ts +++ b/plugin/src/xcode/addBuildPhases.ts @@ -9,6 +9,7 @@ export function addBuildPhases( productFile, enableCompression, resourcesPhaseName, + sourceFiles, }: { targetUuid: string; groupName: string; @@ -20,13 +21,12 @@ export function addBuildPhases( }; enableCompression?: boolean; resourcesPhaseName?: string; + sourceFiles: string[]; }, ) { const buildPath = `"$(CONTENTS_FOLDER_PATH)/AppClips"`; const folderType = "watch2_app"; // "watch2_app" uses the same subfolder spec (16), app_clip does not exist in cordova-node-xcode yet - const buildPhaseFiles = ["AppDelegate.swift"]; - // Add shell script build phase "Start Packager" xcodeProject.addBuildPhase( [], @@ -43,7 +43,7 @@ export function addBuildPhases( // Sources build phase xcodeProject.addBuildPhase( - buildPhaseFiles, + sourceFiles, "PBXSourcesBuildPhase", groupName, targetUuid, diff --git a/plugin/src/xcode/addPbxGroup.ts b/plugin/src/xcode/addPbxGroup.ts index b83ee2d..d118d68 100644 --- a/plugin/src/xcode/addPbxGroup.ts +++ b/plugin/src/xcode/addPbxGroup.ts @@ -22,10 +22,16 @@ export function addPbxGroup( fs.mkdirSync(targetPath, { recursive: true }); } - const filesToCopy = [ - "SplashScreen.storyboard", - "AppDelegate.swift", - ]; + const sourceFiles = ["AppDelegate.swift"]; + if ( + fs.existsSync( + path.join(platformProjectRoot, projectName, "SceneDelegate.swift"), + ) + ) { + sourceFiles.push("SceneDelegate.swift"); + } + + const filesToCopy = ["SplashScreen.storyboard", ...sourceFiles]; for (const file of filesToCopy) { const source = path.join(platformProjectRoot, projectName, file); @@ -51,7 +57,7 @@ export function addPbxGroup( // Add PBX group const { uuid: pbxGroupUuid } = xcodeProject.addPbxGroup( [ - "AppDelegate.swift", + ...sourceFiles, "Info.plist", "Images.xcassets", "SplashScreen.storyboard", @@ -72,6 +78,8 @@ export function addPbxGroup( } } } + + return sourceFiles; } function copyFileSync(source: string, target: string) { From 1e17f0a11f9083db707733a621ec5ac0d8cd9975 Mon Sep 17 00:00:00 2001 From: Nathan Ahn Date: Mon, 9 Nov 2026 17:01:50 -0500 Subject: [PATCH 3/5] Cleaning up CI addition --- .github/workflows/ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b110bed..031c12d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,8 +23,6 @@ jobs: uses: oven-sh/setup-bun@v2 - name: Install dependencies run: bun install --frozen-lockfile - - name: Test config plugin - run: bun run test plugin --watch=false --runInBand - name: Build and pack package run: | mkdir -p "$RUNNER_TEMP/npm-package" From 02f451a7388d590448dbac7ead622723a5e35ab8 Mon Sep 17 00:00:00 2001 From: Nathan Ahn Date: Mon, 9 Nov 2026 17:02:33 -0500 Subject: [PATCH 4/5] Restoring version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 0347f5d..40a4f1a 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "react-native-app-clip", - "version": "0.9.3", + "version": "0.9.2", "packageManager": "bun@1.4.3", "description": "Config plugin to add an App Clip to a React Native iOS app", "main": "build/index.js", From 1096d7fabf410131a8550f07604257391e5b5953 Mon Sep 17 00:00:00 2001 From: Nathan Ahn Date: Mon, 9 Nov 2026 17:02:54 -0500 Subject: [PATCH 5/5] Restoring version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 40a4f1a..0347f5d 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "react-native-app-clip", - "version": "0.9.2", + "version": "0.9.3", "packageManager": "bun@1.4.3", "description": "Config plugin to add an App Clip to a React Native iOS app", "main": "build/index.js",