From fa3194a433a3772ce7b48be67017e1e71c3982d4 Mon Sep 17 00:00:00 2001 From: Evgenii Malygin <2518859+678098@users.noreply.github.com> Date: Wed, 13 May 2026 08:40:26 -0400 Subject: [PATCH 1/2] Fix[ntcd::DataUtil::generateData]: out of bounds write with non-zero offset --- groups/ntc/ntcd/ntcd_datautil.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/groups/ntc/ntcd/ntcd_datautil.cpp b/groups/ntc/ntcd/ntcd_datautil.cpp index cd557f8c..8a1ff48b 100644 --- a/groups/ntc/ntcd/ntcd_datautil.cpp +++ b/groups/ntc/ntcd/ntcd_datautil.cpp @@ -52,7 +52,7 @@ void DataUtil::generateData(bsl::string* result, result->clear(); result->resize(size); - for (bsl::size_t i = offset; i < offset + size; ++i) { + for (bsl::size_t i = offset; i < size; ++i) { (*result)[i] = generateByte(offset + i, dataset); } } From 104b48e56f0d490eb9f72c6fd9bce56f010cd05a Mon Sep 17 00:00:00 2001 From: Matt Millett Date: Wed, 16 Sep 2026 10:24:10 -0400 Subject: [PATCH 2/2] Fix[ntcd::DataUtil::generateData]: index destination string starting at zero --- groups/ntc/ntcd/ntcd_datautil.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/groups/ntc/ntcd/ntcd_datautil.cpp b/groups/ntc/ntcd/ntcd_datautil.cpp index 8a1ff48b..da772272 100644 --- a/groups/ntc/ntcd/ntcd_datautil.cpp +++ b/groups/ntc/ntcd/ntcd_datautil.cpp @@ -52,7 +52,7 @@ void DataUtil::generateData(bsl::string* result, result->clear(); result->resize(size); - for (bsl::size_t i = offset; i < size; ++i) { + for (bsl::size_t i = 0; i < size; ++i) { (*result)[i] = generateByte(offset + i, dataset); } }