Update BattleOrders.js#418
Open
Antiwarden wants to merge 13 commits into
Open
Conversation
Adjusts the giveBo() function in BattleOrders.js to ensure that the script waits only for players who are explicitly defined as getters in the configuration, regardless of any additional players present.
Contributor
Author
|
Might be helpful to track the actual boGetters in the game. If one is missing, they could be temporarily removed from the getters list to speed things up. |
If some of our getters are missing in game, remove them from the boGetters list and proceed.
Last change dropped all getters from the list who were not present at the bo spot. Now, it removes only those from the list who are not in the game.
Fixes an issue where the boGiver would continue to wait even after successfully casting bo on a late-arriving getter after the wait timer had expired. - remove getters from the list after they receive bo - giveBO() function returns immediately once all getters have received bo - stop the main loop once all getters have received bo
- Renamed `removeMissing()` to `getGetters()`
- `getGiver()`: Additional function for boGetters to determine whether the boGiver is in-game and in the same party.
If the giver is not in-game and not in our party after a certain time, BattleOrders.js is terminated.
- `@param {string} Config.BattleOrders.Giver` and
- `@param {int} Config.BattleOrders.WaitForGiver` are required in the character configuration.
- `getGetters()`: Filter not only boGetters that are in-game, but additionally boGetters that still need to be buffed.
- `giveBo()`: Additionally filter `playersToBo` to exclude boGetters that have already been BOed.
- `failTimer`: Reduced timeout for boGetters and boGiver to appear from 2 minutes to 40 seconds.
- `chatEvent()`: Bitwise `|` → logical OR `||`
Removed 'gaveBo' property from BattleOrders.js since it's not needed anymore.
- added role-specific wait timers in `tardy()` function for `Config.BattleOrders.Wait` me.overhead messages - removed redundant return for `boed` flag and `playersToBo` count - throw an error if `boGiver` hasn't specified any `boGetters` - added guard for `boMode.Give` case to exit the `MainLoop` if `boGetters` is empty - formatting
Add guard in `boMode.Give` case to exit the MainLoop if `boGetters` is empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusts the
giveBo()function inBattleOrders.jsto ensure that the script waits only for players who are explicitly defined as getters in the configuration, regardless of any additional players present.