From 81c2b1091eaca4bbbe20fa126939d4ebd005f764 Mon Sep 17 00:00:00 2001
From: Steffen Bewersdorff <steffen@bleech.de>
Date: Mon, 30 Mar 2026 17:06:10 +0200
Subject: [PATCH] Default settings inputs autocomplete to off and enable email
 autofill for notifications

---
 components/settings-page/index.php              |  2 +-
 includes/core/settings/field-password/index.php |  1 +
 includes/core/settings/field-text/index.php     |  6 +++++-
 includes/features/class-settings-page.php       | 11 +++++++++++
 4 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/components/settings-page/index.php b/components/settings-page/index.php
index fd4d5f1..58fbeb6 100644
--- a/components/settings-page/index.php
+++ b/components/settings-page/index.php
@@ -5,7 +5,7 @@
 ?>
 <vrts-settings class="wrap vrts-settings">
 	<h1><?php echo esc_html( $data['title'] ); ?></h1>
-	<form method="post" action="options.php">
+	<form method="post" action="options.php" autocomplete="off">
 	<?php
 		settings_fields( $data['settings_fields'] );
 		do_settings_sections( $data['settings_sections'] );
diff --git a/includes/core/settings/field-password/index.php b/includes/core/settings/field-password/index.php
index b590c83..6b64575 100644
--- a/includes/core/settings/field-password/index.php
+++ b/includes/core/settings/field-password/index.php
@@ -5,6 +5,7 @@ class="regular-text"
 		name="<?php echo esc_attr( $args['id'] ); ?>"
 		value="<?php echo esc_attr( $value ); ?>"
 		placeholder="<?php echo esc_attr( $args['placeholder'] ); ?>"
+		autocomplete="<?php echo esc_attr( $args['autocomplete'] ?? 'off' ); ?>"
 		<?php wp_readonly( isset( $args['readonly'] ) && $args['readonly'] ); ?>
 		<?php disabled( isset( $args['disabled'] ) && $args['disabled'] ); ?>>
 	<?php
diff --git a/includes/core/settings/field-text/index.php b/includes/core/settings/field-text/index.php
index 0a6b999..9171147 100644
--- a/includes/core/settings/field-text/index.php
+++ b/includes/core/settings/field-text/index.php
@@ -1,10 +1,14 @@
 <fieldset <?php echo isset( $args['is_pro'] ) && false === $args['is_pro'] ? 'data-a11y-dialog-show="vrts-modal-pro-settings"' : ''; ?>>
 	<input
-		type="text" id="<?php echo esc_attr( $args['id'] ); ?>"
+		type="<?php echo esc_attr( $args['input_type'] ?? 'text' ); ?>" id="<?php echo esc_attr( $args['id'] ); ?>"
 		class="regular-text"
 		name="<?php echo esc_attr( $args['id'] ); ?>"
 		value="<?php echo esc_attr( $value ); ?>"
 		placeholder="<?php echo esc_attr( $args['placeholder'] ); ?>"
+		autocomplete="<?php echo esc_attr( $args['autocomplete'] ?? 'off' ); ?>"
+		<?php if ( isset( $args['multiple'] ) && $args['multiple'] ) : ?>
+			multiple="multiple"
+		<?php endif; ?>
 		<?php wp_readonly( isset( $args['readonly'] ) && $args['readonly'] ); ?>
 		<?php disabled( isset( $args['disabled'] ) && $args['disabled'] ); ?>>
 	<?php
diff --git a/includes/features/class-settings-page.php b/includes/features/class-settings-page.php
index 3b61d66..709a1b0 100644
--- a/includes/features/class-settings-page.php
+++ b/includes/features/class-settings-page.php
@@ -93,6 +93,7 @@ public function add_settings() {
 			'sanitize_callback' => 'sanitize_text_field',
 			'show_in_rest' => true,
 			'value_type' => 'string',
+			'autocomplete' => 'off',
 			'default' => '',
 		]);
 
@@ -111,6 +112,7 @@ public function add_settings() {
 			'sanitize_callback' => 'sanitize_text_field',
 			'show_in_rest' => true,
 			'value_type' => 'string',
+			'autocomplete' => 'off',
 			'value' => ! empty( vrts()->settings()->get_option( 'vrts_license_key', false ) ) ? 'XXXXXXXX-XXXXXXXX-XXXXXXXX-XXXXXXXX' : '',
 			'default' => '',
 		]);
@@ -201,6 +203,9 @@ public function add_settings() {
 			'title' => esc_html__( 'Schedule', 'visual-regression-tests' ),
 			'description' => esc_html__( 'Separate multiple email addresses with commas. Or leave blank to disable notifications.', 'visual-regression-tests' ),
 			'placeholder' => esc_html__( 'Email address(es)', 'visual-regression-tests' ),
+			'input_type' => 'email',
+			'multiple' => true,
+			'autocomplete' => 'email',
 			'sanitize_callback' => [ Sanitization::class, 'sanitize_multiple_emails' ],
 			'show_in_rest' => true,
 			'value_type' => 'string',
@@ -214,6 +219,9 @@ public function add_settings() {
 			'section' => 'vrts-settings-section-notifications',
 			'title' => esc_html__( 'Update', 'visual-regression-tests' ),
 			'placeholder' => esc_html__( 'Email address(es)', 'visual-regression-tests' ),
+			'input_type' => 'email',
+			'multiple' => true,
+			'autocomplete' => 'email',
 			'sanitize_callback' => [ Sanitization::class, 'sanitize_multiple_emails' ],
 			'show_in_rest' => true,
 			'value_type' => 'string',
@@ -229,6 +237,9 @@ public function add_settings() {
 			'section' => 'vrts-settings-section-notifications',
 			'title' => esc_html__( 'API', 'visual-regression-tests' ),
 			'placeholder' => esc_html__( 'Email address(es)', 'visual-regression-tests' ),
+			'input_type' => 'email',
+			'multiple' => true,
+			'autocomplete' => 'email',
 			'sanitize_callback' => [ Sanitization::class, 'sanitize_multiple_emails' ],
 			'show_in_rest' => true,
 			'value_type' => 'string',