fix(core): stop infinite parent-walk bug in hasCatchChain crashing extraction

Author: blaycoder

packages/core/src/parse/api-extractor.test.ts

@@ -144,6 +144,22 @@ describe('extractApiCalls', () => {
       const call = single("fetch('/u')")
       expect(call.hasErrorHandler).toBe(false)
     })
+
+    it('does not throw for await fetch inside async function (regression)', () => {
+      const source = `
+export async function loadItems() {
+  const res = await fetch('/api/items', { headers: { Accept: 'application/json' } });
+  const body = await res.json().catch(() => ({}));
+  return body;
+}
+`
+      const calls = extract(source)
+      expect(calls.length).toBeGreaterThanOrEqual(1)
+      const fetchCall = calls.find((c) => c.caller === 'fetch')
+      expect(fetchCall).toBeDefined()
+      expect(fetchCall!.url).toBe('/api/items')
+      expect(fetchCall!.hasErrorHandler).toBe(false)
+    })
   })
 
   describe('known false positives', () => {

packages/core/src/parse/api-extractor.ts

@@ -497,12 +497,12 @@ function isInsideTryCatch(node: ts.Node): boolean {
 }
 
 function hasCatchChain(node: ts.CallExpression): boolean {
-  // Walk up property access chains: fetch(...).then(...).catch(...)
-  for (let current: ts.Node = node; ; current = current.parent) {
-    const parent = current.parent
-
-    // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition -- SourceFile has no parent
-    if (!parent) return false
+  // Walk up from node; check whether any ancestor is a .catch / .then(_, reject) chain.
+  // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition -- AST root may lack a parent
+  for (let parent = node.parent; parent; parent = parent.parent) {
+    if (ts.isSourceFile(parent)) {
+      return false
+    }
 
     if (ts.isPropertyAccessExpression(parent) && parent.name.text === 'catch') {
       return true
@@ -522,9 +522,9 @@ function hasCatchChain(node: ts.CallExpression): boolean {
     if (ts.isExpressionStatement(parent) || ts.isVariableDeclaration(parent)) {
       return false
     }
-
-    current = parent
   }
+
+  return false
 }
 
 function getLocation(node: ts.Node, sourceFile: ts.SourceFile): SourceLocation {

packages/core/src/runner/scanner.ts

@@ -147,9 +147,10 @@ export async function scan(config: ScanConfig): Promise<ScanResult> {
       allApiCalls.push(...calls)
     } catch (cause) {
       filesErrored++
+      const detail = cause instanceof Error ? cause.message : String(cause)
       diagnostics.push({
         kind: 'parse-error',
-        message: `Failed to parse ${file.relativePath}`,
+        message: `Failed to parse ${file.relativePath}: ${detail}`,
         file: file.absolutePath,
         cause: cause instanceof Error ? cause : new Error(String(cause)),
       })