From 2757923aed89b834a052b16ff48553ab5968a8fe Mon Sep 17 00:00:00 2001 From: Georgy Butaev <41178744+g-but@users.noreply.github.com> Date: Sat, 29 Aug 2026 11:33:16 +0200 Subject: [PATCH] fix(notifications): make the unconfigured-email warning read as an outage MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Peer review on the log-flood fix (PR #841) flagged that "email notifications are disabled" reads as a benign default, not the outage it is — a quiet single warning is easy to miss, and this removes the only signal that notifications are being dropped. Reworded to say plainly that emails are being discarded and name the provider, so one grep hit is enough to act on. --- src/services/notifications/dispatcher.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/services/notifications/dispatcher.ts b/src/services/notifications/dispatcher.ts index 2ca95407c..b02ef2e86 100644 --- a/src/services/notifications/dispatcher.ts +++ b/src/services/notifications/dispatcher.ts @@ -165,8 +165,9 @@ export class NotificationDispatcher { if (!_unconfiguredWarned) { _unconfiguredWarned = true; logger.warn( - 'RESEND_API_KEY is not set — email notifications are disabled. ' + - 'This warns once per process, not once per notification.', + 'Dropping email notifications: RESEND_API_KEY (Resend) is unset. ' + + 'Every notification email since process start has been silently discarded. ' + + 'This warns once per process, not once per notification — treat one line as an ongoing outage, not a benign default.', {}, LOG_SOURCE );