S038: Check Schema declares Default with incompatible Type#329
Open
magodo wants to merge 3 commits into
Open
Conversation
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new schema check that reports cases of Schemas which has
Defaultvalue declared with incompatibleType.The logic is to look at the schema definitions that have non-nil
Defaultdeclared in AST, then check if the "Default" field in the schema info is evaluated to be nil, which only happens when theDefaultvalue doesn't have the same type as the schema type (covers int, string and bool).Since the existing basic literal check only checks for the
ast.BasicLitnode, whilst it can happen that theDefaultvalue can be some other expression (e.g.string(MyStringABC), whereconst MyStringABC MyString = "abc"; Or evenMyStringABC). This PR also extends a set of similar functions, but account for the constant value of the expression assigned as theDefaultvalue.Test
tfproviderlint/passes/S038 on S038 via 🐹 v1.24.0 💤 go test ./... ok github.com/bflad/tfproviderlint/passes/S038 (cached)