Skip to content

fix: show correct storage unit in file chart and include db/file name… #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Seme30 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: show correct storage unit in file chart and include db/file name… #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/components/charts/fileChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,16 +180,16 @@ export const FileChart = ({ url }: { url: string }) => {
a: number,
e: {
maxSize?: number | null;
currentSize?: number | null;
usedSize?: number | null;
used?: number | null;
free?: number | null;
},
) =>
Math.max(
Number(a),
Math.max(
Number(e.maxSize) || 0,
Number(e.currentSize) || 0,
Number(e.usedSize) || 0,
Number(e.used) || 0,
(Number(e.used) || 0) + (Number(e.free) || 0),
),
),
0,
Expand Down
7 changes: 4 additions & 3 deletions app/notifications/checks/monitors/sqlFiles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,10 @@ async function allClear({
);

return Logger({
message: `Free space now below limit of ${monitor.sqlFileSizePercentFreeValue}%`,
message: `[${database.name} file ${file.fileName}] Free space now below limit of ${monitor.sqlFileSizePercentFreeValue}%`,
type: "success",
monitor,
database,
file,
});
}
Expand Down Expand Up @@ -129,7 +130,7 @@ export default async function sqlFilePercentFreeNotifier({
percFree < (monitor.sqlFileSizePercentFreeValue || 0)
) {
// alert for fixed file size
message = `(Growth disabled) Percentage of free space (${Math.round(
message = `[${database.name} file ${file.fileName}] (Growth disabled) Percentage of free space (${Math.round(
percFree,
)}%) is less than the limit of ${
monitor.sqlFileSizePercentFreeValue
Expand All @@ -140,7 +141,7 @@ export default async function sqlFilePercentFreeNotifier({
percFreeMax < (monitor.sqlFileSizePercentFreeValue || 0)
) {
// alert for max file size
message = `(Max file size) Percentage of free space (${Math.round(
message = `[${database.name} file ${file.fileName}] (Max file size) Percentage of free space (${Math.round(
percFreeMax,
)}%) is less than the limit of ${
monitor.sqlFileSizePercentFreeValue
Expand Down