Unable to deploy dags in v0.9.0

[nsivapra]

I've recently upgraded the deploy actions from astronomer/deploy-action@v0.4.0 to astronomer/deploy-action@v0.9.0 to use wake-on-deploy. However, I'm noticing none of the dag deploys and updates are appearing in the instance.

Github actions:

    - name: Deploy to ephemeral instance
      uses: astronomer/deploy-action@v0.9.0
      with:
        preview-name: '${{ github.event.pull_request.head.ref }}-ephemeral'
        root-folder: ./astro
        action: deploy-deployment-preview
        force: true
        checkout: false
        deployment-id: [deployment_id]
        wake-on-deploy: true

File update in actions:

• 1 file is updated

Astro instance:

• No updates for this dag update

Am I missing anything in setting up this action?

[zerodarkzone]

Hi, I'm having the same issue

[DarrenBaldwin07]

+1 can confirm i'm experiencing the same issue but only on v0.9.0 - went back to v0.4 and its working fine.

[ryw]

@schnie :)

[DarrenBaldwin07]

Also, i've been seeing the action only deploy dag changes even when i have deploy-type: image-and-dags set in the action (this is on v0.4 because v0.9 does nothing when triggering a new deploy as described in the parent description for this issue)

EDIT: looks like deploy-type flag was not added until v0.9

[ryw]

@schnie can we get eyes on this? We're just trying to setup CI/CD and always build image + deploy days.

[schnie]

Thanks for the report. Taking a look into this with the team.

While we get some eyes on it, @nsivapra @zerodarkzone @DarrenBaldwin07 curious if v0.8.0 (or any other versions greater than v0.4.0) work for you. Trying to narrow in on what change may have caused a regression here.

It looks like deploy-type option was added in v0.7.1 v0.7...v0.7.1. 🤔

[neel-astro]

@nsivapra, can you confirm the following:

• Is the "1 file updated" in the workflow run that is shared in the issue located inside the configured root-folder (i.e., ./astro)?
• What is the trigger condition configured for the deploy action? Also is it a merge commit created on merging the PR or a simple squash and merge commit that is represented in the example?
• Also you might want to set the root-folder value as just "astro" instead of "./astro" (This might not solve the shared example problem, but it will avoid future problems :))

The reason you are running into this issue is due to the recently updated logic in the deploy action where it is trying to compute file changes that triggered the workflow to determine if it needs to do an image deploy or a dag deploy (Reference: https://github.com/astronomer/deploy-action/blob/v0.9.0/action.yaml#L380-L381). The computation is returning no files changed.

@DarrenBaldwin07 can you confirm if the behavior you are running into is the same? Also, would be helpful if you could share the deploy action configuration, workflow logs, and files that are changing in that workflow run.