Skip to content

Commit a4495f2

Browse files
committed
ci: integrate typechecking & format checking into checks
- remove checks and fix all scripts as not all lint errors can be fixed at the moment
1 parent 88877e7 commit a4495f2

File tree

4 files changed

+4
-5
lines changed

4 files changed

+4
-5
lines changed

.github/workflows/checks.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,6 @@ jobs:
1818
with:
1919
cache: true
2020
- run: pdm install
21+
- run: pdm run typecheck:all
22+
- run: pdm run format --check
2123
- run: pdm run test:unit

pyproject.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ lint = "ruff check src tests"
4949
"lint:fix" = "ruff check --fix src tests"
5050
typecheck = "mypy"
5151
"typecheck:all" = "mypy src tests"
52-
checks = {composite = ["format . --check", "lint", "typecheck"]}
53-
fix-all = {composite = ["format", "lint:fix", "typecheck"]}
5452
chat = "streamlit run src/askui/chat/__main__.py"
5553

5654
[dependency-groups]

src/askui/locators/locators.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ def _str(self) -> str:
3333
return "locator"
3434

3535

36-
3736
class Prompt(Locator):
3837
"""Locator for finding ui elements by a textual prompt / description of a ui element, e.g., "green sign up button".
3938

src/askui/models/huggingface/spaces_api.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,13 @@ def get_space_client(self, space_name: str) -> Client:
3131
return self.clients[space_name]
3232

3333
@staticmethod
34-
def _rescale_bounding_boxes(
34+
def _rescale_bounding_boxes( # type: ignore
3535
bounding_boxes,
3636
original_width,
3737
original_height,
3838
scaled_width=1000,
3939
scaled_height=1000,
40-
): # type: ignore
40+
):
4141
x_scale = original_width / scaled_width
4242
y_scale = original_height / scaled_height
4343
rescaled_boxes = []

0 commit comments

Comments
 (0)