Skip to content

Overlay should be destroyed togeter with window #11

Description

Overlay should be destroyed together with window

Currently window is being destroyed in MooDialog.destroy, but overlay is left orphaned. To fix this I would suggest the following changes


// Modyfy MooDialog.destroy to fire "destroy" event
destroy: function(){
      this.fireEvent('destroy');
        this.wrapper.destroy();
    },

// handle this event in MooDialog.Fx
onDestroy : function() {
      this.overlay.destroy();
    }

// finally add "destroy" method to Overlay class
destroy : function() {
      this.overlay.destroy();
    }

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions