Introduce MMark#1492
Open
mmissiato wants to merge 2 commits into
Open
Conversation
highlight relevant text using mark.js
NikitaFil
reviewed
May 20, 2025
Contributor
NikitaFil
left a comment
NikitaFil
left a comment
There was a problem hiding this comment.
Generally, looks good. Do not forget to make sure we have rights to use mark.js
| [ | ||
| \-> { | ||
| // DOM not ready on first call: Can't find element. | ||
| deferUntilRender(\-> hostCall("performMark", [fgetValue(text), querySelectorField])|>ignore); |
Contributor
There was a problem hiding this comment.
deferUntilNextFrameRendered
| return null; | ||
| } | ||
|
|
||
| const textWidgets = rootElement.querySelectorAll('.textWidget'); |
Contributor
There was a problem hiding this comment.
TODO: Add a filter for textwidgets we'd like to ignore.
| <script type="text/javascript" src="js/pixi.filters.js?10" defer></script> | ||
| <script type="text/javascript" src="js/jscommon.js?14" defer></script> | ||
| <script type="text/javascript" src="js/purify/purify.min.js?1" defer></script> | ||
| <script type="text/javascript" src="js/mark/mark.min.js" defer></script> |
Contributor
There was a problem hiding this comment.
It would be better to add them dynamically on first MMark usage (create a helper function in Haxe)
| @@ -1,6 +1,6 @@ | |||
| *:not(body):not(html) { | |||
| /* *:not(body):not(html) { | |||
Contributor
There was a problem hiding this comment.
We should have a probation period with this part deleted under 'new=1', before merging MMark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
highlight relevant text using mark.js
Usage: https://git.area9lyceum.com/Lyceum/lyceum/pulls/9678