Introduced FLiftExpensive to avoid calling expansive functions again#1491
Open
Eugeny48 wants to merge 2 commits into
Open
Introduced FLiftExpensive to avoid calling expansive functions again#1491Eugeny48 wants to merge 2 commits into
FLiftExpensive to avoid calling expansive functions again#1491Eugeny48 wants to merge 2 commits into
Conversation
Reworked `instantiateFn2Lazy`, now it returns `Maybe`; Restored optimization for lazy Transforms in `fselect2`; Test updated, lazy transforms involved;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use Transform a lot. But sometimes Transform behaves unclear.
For example we can use transforms to create trees.
We do not expect to recalculate this expensive tree until learnersB changes.
But it happens if we use
classId2learnersTinfselect2, becausefselect2creates new function from our expansive function.We do not want to change this behavior, because as @NikitaFil says, it may increase the number of DynamicBehaviours and memory consumption.
So we need
FLiftExpensiveto mark expensive functions and avoid unwanted recalculations.Here is a test example https://github.com/area9innovation/flow9/compare/FLiftExpensive?expand=1#diff-97db1eea617660e99c205157e61ab96a911c7206daa6b1261e5149885ca19524
Output:
As you can see from the example above, an additional benefit of
FLiftExpensiveis that initializing a transform also initializes the influencing transforms withFLiftExpensive, even if they are behindfselect2.