Improve fthrottle2 by using movableTimer;#1470
Open
Eugeny48 wants to merge 1 commit into
Open
Conversation
Contributor
Author
NikitaFil
approved these changes
Apr 10, 2025
Contributor
NikitaFil
left a comment
NikitaFil
left a comment
There was a problem hiding this comment.
Looks fine for me. One more minor change - maxDelta is in fact minDelta, worth renaming.
Requested review from Yuriy as well, since fthtottle2 and MThrottleMetrics are used in Wigi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google.Chrome.2025-04-08.19-39-13.mp4
I'm not sure if this is really useful, but in the case in the attached video it replaces 4 redraws with 2.
The hover triggers more then 5k calls to interruptibleTimer inside fthrottle2.