arrayutils: splitModulo and concatAModulo are made total

[dmitry-vlasov]

No description provided.

[shkel]

how many times are these functions used? (splitModulo and concatAModulo).
if no one uses them (1-2 times), then they should not be in the library at all. Why they are needed and what they do is also unclear.

[shkel]

j=0 always

[dmitry-vlasov]

ok, fixed.

[shkel]

unsafe retrieval of element by index

[dmitry-vlasov]

Here retrieval is safe. It may be proved.

[shkel]

for is not a functional style. please, don't use for

[dmitry-vlasov]

for function itself is completely functional (see its definition). What is not "functional" here is usage of references. I use references to get efficiency and clear small implementation of a function.

[dmitry-vlasov]

how many times are these functions used? (splitModulo and concatAModulo).
if no one uses them (1-2 times), then they should not be in the library at all. Why they are needed and what they do is also unclear.

I used these functions. What do these functions - I already explained to you thoroughfully. The concise explanation is given in comments. The general character of these functions mean that their place in the general library.

[shkel]

I used these functions.

used or use ? I suggest removing these functions

[dmitry-vlasov]

used or use ? I suggest removing these functions

I cite your message: "люди ее используют так, как описано в комментарии. я не вижу проблемы чтобы убрать креш и соединить массивы. (People use it as it is described in a comment. I don't see a problem in fixing a crash and joining arrays)".
So you say yourself that someone uses it, why do yo suggest to remove these functions? You asked to make theses functions total - I fulfilled your request, so what's the problem now?

[shkel]

used or use ? I suggest removing these functions

I cite your message: "люди ее используют так, как описано в комментарии. я не вижу проблемы чтобы убрать креш и соединить массивы. (People use it as it is described in a comment. I don't see a problem in fixing a crash and joining arrays)". So you say yourself that someone uses it, why do yo suggest to remove these functions? You asked to make theses functions total - I fulfilled your request, so what's the problem now?

i do NOT use it. i found 2 uses of concatAModulo , and 0 of splitModulo

[dmitry-vlasov]

used or use ? I suggest removing these functions

I cite your message: "люди ее используют так, как описано в комментарии. я не вижу проблемы чтобы убрать креш и соединить массивы. (People use it as it is described in a comment. I don't see a problem in fixing a crash and joining arrays)". So you say yourself that someone uses it, why do yo suggest to remove these functions? You asked to make theses functions total - I fulfilled your request, so what's the problem now?

i do NOT use it. i found 2 uses of concatAModulo , and 0 of splitModulo

1. Why do you think that if you don't use it, nobody ever won't use it?
2. Functions concatAModulo and splitModulo naturally come in pair since one is the reverse for the other.