Flowc java long strings#1184
Open
dmitry-vlasov wants to merge 2 commits into
Open
Conversation
Eugeny48
reviewed
Apr 12, 2023
Comment on lines
+452
to
+453
| n0 = s_len / len; | ||
| n = if (s_len == (n0 * len)) n0 else n0 + 1; |
Contributor
There was a problem hiding this comment.
Suggested change
| n0 = s_len / len; | |
| n = if (s_len == (n0 * len)) n0 else n0 + 1; | |
| n = (s_len - 1) / len + 1; |
Eugeny48
reviewed
Apr 12, 2023
| // TODO: We use UTF-16, so to be sure about long strings is it enough 32000 as a safe border? ... | ||
| long_string_ind = length(^(ctx.func.gctx.longStrings)); | ||
| (ctx.func.gctx).longStrings := concat(^(ctx.func.gctx.longStrings), [s]); | ||
| result("LongStrings.longString" + i2s(long_string_ind) + "()", "String"); |
Contributor
There was a problem hiding this comment.
Can we create this long string only once? Maybe rework function-member into a field?
Contributor
|
Can we move these long strings from code to a resource file? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.