Skip to content

TemporalProperties getActivityWorkers using workflowDefaults #25

Description

@r-murphy

In TemporalProperties getActivityWorkers method, some of the defaults are taken from workflowDefaults rather than activityWorkerDefaults.

Specifically, these 2:

if (value.getWorkflowPollThreadPoolSize() == null) {
    value.setWorkflowPollThreadPoolSize(workflowDefaults.getWorkflowPollThreadPoolSize());
}
if (value.getActivityPollThreadPoolSize() == null) {
    value.setActivityPollThreadPoolSize(workflowDefaults.getActivityPollThreadPoolSize());
}

Is this intentional or accidental?

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions