Spell Checker Interface [WIP] by JPJPJPOPOP · Pull Request #253 · apertium/apertium-html-tools

JPJPJPOPOP · 2018-01-05T07:32:40Z

Deconflicted SpellChecker Interface #176
Fixed miscellaneous comments
Added flow annotations to spellchecker.js

houndci-bot · 2018-01-05T07:32:50Z

+                content[splitWords[originalWordsIndex]] = '<div class="list-group">';
+                for(var sugg = 0; sugg < data[tokenIndex]['sugg'].length; sugg++) {
+                    content[splitWords[originalWordsIndex]] += '<a href="#" class="list-group-item">' +
+                        data[tokenIndex]['sugg'][sugg][0] + '</a>';


["sugg"] is better written in dot notation dot-notation

houndci-bot · 2018-01-05T07:32:50Z

+                $('#spellcheckerInput').html($('#spellcheckerInput').html() + ' <span class="spellError" id=' +
+                    splitWords[originalWordsIndex] + '>' + splitWords[originalWordsIndex] + '</span>');
+                content[splitWords[originalWordsIndex]] = '<div class="list-group">';
+                for(var sugg = 0; sugg < data[tokenIndex]['sugg'].length; sugg++) {


["sugg"] is better written in dot notation dot-notation

houndci-bot · 2018-01-05T07:32:50Z

+        success: function (data) {
+            var originalWordsIndex = 0;
+            for(var tokenIndex = 0; tokenIndex < data.length; tokenIndex++) {
+                if(data[tokenIndex]['known'] === true) {


["known"] is better written in dot notation dot-notation

houndci-bot · 2018-01-06T04:54:39Z

+                placement: 'bottom',
+                trigger: 'manual',
+                html: true,
+                content: content[currentTokenId]


'content' is not defined no-undef

houndci-bot · 2018-01-06T04:54:39Z

+        for(var sugg = 0; sugg < data[tokenIndex].sugg.length; sugg++) {
+            content[splitWords[originalWordsIndex]] += '<a href="#" class="spellCheckerListItem">' +
+                data[tokenIndex].sugg[sugg][0] + '</a>';
+            content[splitWords[originalWordsIndex]] += '</div>';


'content' is not defined no-undef
'splitWords' is not defined no-undef

houndci-bot · 2018-01-06T04:54:39Z

+            splitWords[originalWordsIndex] + '>' + splitWords[originalWordsIndex] + '</span>');
+        content[splitWords[originalWordsIndex]] = '<div class="spellCheckerList">';
+        for(var sugg = 0; sugg < data[tokenIndex].sugg.length; sugg++) {
+            content[splitWords[originalWordsIndex]] += '<a href="#" class="spellCheckerListItem">' +


'content' is not defined no-undef
'splitWords' is not defined no-undef

houndci-bot · 2018-01-06T04:54:39Z

+        }
+        $('#spellCheckerInput').html($('#spellCheckerInput').html() + ' <span class="spellError" id=' +
+            splitWords[originalWordsIndex] + '>' + splitWords[originalWordsIndex] + '</span>');
+        content[splitWords[originalWordsIndex]] = '<div class="spellCheckerList">';


'content' is not defined no-undef
'splitWords' is not defined no-undef

houndci-bot · 2018-01-06T04:54:39Z

+            continue;
+        }
+        $('#spellCheckerInput').html($('#spellCheckerInput').html() + ' <span class="spellError" id=' +
+            splitWords[originalWordsIndex] + '>' + splitWords[originalWordsIndex] + '</span>');


'splitWords' is not defined no-undef

houndci-bot · 2018-01-06T04:54:39Z

+    var originalWordsIndex = 0;
+    for(var tokenIndex = 0; tokenIndex < data.length; tokenIndex++) {
+        if(data[tokenIndex].known === true) {
+            $('#spellCheckerInput').html($('#spellCheckerInput').html() + ' ' + splitWords[originalWordsIndex]);


'splitWords' is not defined no-undef

sushain97

Initial run through, looking on the right track. Haven't tested it yet though.

I don't have too much time right now so I couldn't take a more detailed look.

sushain97 · 2018-01-06T08:15:17Z

 	assets/js/generator.js \
-	assets/js/sandbox.js
+	assets/js/sandbox.js \
+        assets/js/spellchecker.js


@sushain97 this is weird, it looks fine in the actual file, but looks wrong here.

sushain97 · 2018-01-06T08:15:40Z

 /* global config, getPairs, getGenerators, getAnalyzers, persistChoices, getURLParam, cache, ajaxSend, ajaxComplete, sendEvent,
    srcLangs, dstLangs, generators, analyzers, readCache, modeEnabled, populateTranslationList, populateGeneratorList,
-    populateAnalyzerList, analyzerData, generatorData, curSrcLang, curDstLang, restoreChoices, refreshLangList, onlyUnique */
+    populateAnalyzerList, analyzerData, generatorData, curSrcLang, curDstLang, restoreChoices, refreshLangList, onlyUnique


Missing a comma?

sushain97 · 2018-01-06T08:17:48Z

+        'translation': getPairs,
+        'generation': getGenerators,
+        'analyzation': getAnalyzers,
+        'spellchecker': getSpellers


Is it just me or is something off, shouldn't it be 'spell checking'? Otherwise, 'translation' would be 'translator', etc.

(and in other analagous places)

sushain97 · 2018-01-06T08:20:30Z

+                              </div>
+                              <div class="col-sm-4">
+                                  <select class="form-control spellCheckerMode" id="secondarySpellCheckerMode" name="secondarySpellCheckerMode">
+                                      <option> </option>


sushain97 · 2018-01-06T08:20:58Z

+}
+
+function spellCheckerNotAvailable(data) {
+    $('#spellCheckerInput').append($('<div></div>').text(' '));


What's the point of .text(' ')?

sushain97 · 2018-01-06T08:26:46Z

Also, please add the flow annotation to spellchecker.js (which should probably be called spellchecking.js)?

sushain97 · 2018-01-06T19:43:55Z

Tabs vs spaces

…

On Jan 6, 2018 1:36 PM, "Jonathan Pan" ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Makefile <#253 (comment)> : > @@ -46,7 +46,8 @@ JSFILES= \ assets/js/translator.js \ assets/js/analyzer.js \ assets/js/generator.js \ - assets/js/sandbox.js + assets/js/sandbox.js \ + assets/js/spellchecker.js @sushain97 <https://github.com/sushain97> this is weird, it looks fine in the actual file, but looks wrong here. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#253 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEBEfglOyBpzEr5YHiWD_qo8YLQKYwmaks5tH8s-gaJpZM4RUHst> .

JPJPJPOPOP · 2018-01-06T20:23:54Z

@sushain97 I don't think it should be called spellchecking.js, because there are already files in the assets/js like translator.js, generator.js, etc.

sushain97 · 2018-01-08T04:25:34Z

It looks like there are two dropdowns here:

However, only tat provides a speller:

$ curl http://localhost:2737/list?q=spellers
{"oci": "oci-spell", "crh": "crh-spell", "kaz": "kaz-spell", "kir": "kir-spell", "hin": "hin-spell", "tat": "tat-spell", "tyv": "tyv-spell"}

What gives?

sushain97 · 2018-01-08T04:26:53Z

Also, please undo your test data commit since I got this up with real data.

houndci-bot · 2018-01-08T05:26:01Z

+var currentSpellCheckerRequest;
+
+/* exported getSpellers, populateSecondarySpellCheckerList */
+/* global config, modeEnabled, persistChoices, readCache, ajaxSend, ajaxComplete, filterLangPairList, allowedLang, analyzers, cache,


'analyzers' is defined but never used no-unused-vars

sushain97 · 2018-01-09T02:35:40Z

Couple concerns:

language name selector should have localized names? they're correct in other places

seems to be glitchy if the API doesn't provide any suggestions?

houndci-bot · 2018-01-09T03:38:19Z

+                    deferred.resolve();
+                }
+            });*/
+            var data = {"eng":"test1"};


Strings must use singlequote quotes
Missing space before value for key 'eng' key-spacing

houndci-bot · 2018-01-09T03:38:19Z

+        if(modeEnabled('spellchecking')) {
+            populatePrimarySpellCheckerList(spellerData);
+        }   
+


Trailing spaces not allowed no-trailing-spaces

houndci-bot · 2018-01-09T03:38:20Z

        }
+        if(modeEnabled('spellchecking')) {
+            populatePrimarySpellCheckerList(spellerData);
+        }   


Trailing spaces not allowed no-trailing-spaces

houndci-bot · 2018-01-09T03:38:20Z

 /* global config, getPairs, getGenerators, getAnalyzers, persistChoices, getURLParam, cache, ajaxSend, ajaxComplete, sendEvent,
    srcLangs, dstLangs, generators, analyzers, readCache, modeEnabled, populateTranslationList, populateGeneratorList,
-    populateAnalyzerList, analyzerData, generatorData, curSrcLang, curDstLang, restoreChoices, refreshLangList, onlyUnique */
+    populateAnalyzerList, populatePrimarySpellCheckerList, analyzerData, generatorData, spellerData, curSrcLang, curDstLang, restoreChoices, refreshLangList, onlyUnique,


Line 16 exceeds the maximum line length of 140 max-len

houndci-bot · 2018-01-09T04:06:38Z

+            }
+            $('.spellError').each(function () {
+                var currentTokenId = this.id;
+                if(content[currentTokenId].indexOf("spellCheckerListItem") !== -1) {


Strings must use singlequote quotes

JPJPJPOPOP · 2018-01-21T03:39:05Z

        '#analyzation': 'qA',
-        '#generation': 'qG'
+        '#generation': 'qG',
+        '#spellchecking': 'qS'


@sushain97 This currently conflicts with sandbox. What should I change this to?

I don't really think sandbox needs one...

@sushain97 It at least needs something, otherwise errors start popping up and breaks the UI.

Or let's just make it qSand.

STSARC001 · 2023-03-18T11:37:15Z

hello everyone i am A frontend Devolper And i Want to be part of Your Community In This GSOC 2023
i Will Clear this Spell Checker Issue With the Help of API

Name :- Abhijit Dengale
email:- dengaleabhijit6@gmail.com

@jonorthwash @xavivars

houndci-bot reviewed Jan 5, 2018

View reviewed changes

JPJPJPOPOP force-pushed the spellchecker branch 5 times, most recently from a2ea8f0 to 7583760 Compare January 6, 2018 04:54

houndci-bot reviewed Jan 6, 2018

View reviewed changes

JPJPJPOPOP force-pushed the spellchecker branch 2 times, most recently from c52e3ae to 02ab612 Compare January 6, 2018 06:06

JPJPJPOPOP changed the title ~~Spellchecker Interface [WIP]~~ Spell Checker Interface [WIP] Jan 6, 2018

JPJPJPOPOP force-pushed the spellchecker branch 2 times, most recently from b5960d5 to 1f1165c Compare January 6, 2018 06:22

apertium deleted a comment from houndci-bot Jan 6, 2018

sushain97 requested changes Jan 6, 2018

View reviewed changes

JPJPJPOPOP force-pushed the spellchecker branch 12 times, most recently from 939d8b6 to f3537ab Compare January 7, 2018 00:00

JPJPJPOPOP force-pushed the spellchecker branch from abbbab9 to abd87e2 Compare January 8, 2018 04:28

houndci-bot reviewed Jan 8, 2018

View reviewed changes

JPJPJPOPOP force-pushed the spellchecker branch from 2f53ae9 to cec0819 Compare January 8, 2018 05:27

JPJPJPOPOP force-pushed the spellchecker branch from 7d9a9e5 to b541da3 Compare January 9, 2018 02:56

houndci-bot reviewed Jan 9, 2018

View reviewed changes

JPJPJPOPOP force-pushed the spellchecker branch from 9b53135 to 1fc6ce5 Compare January 9, 2018 03:42

houndci-bot reviewed Jan 9, 2018

View reviewed changes

JPJPJPOPOP force-pushed the spellchecker branch 3 times, most recently from d501dc1 to 649fb8c Compare January 9, 2018 04:10

apertium deleted a comment from houndci-bot Jan 9, 2018

sushain97 force-pushed the master branch from 536a5d5 to b2946d3 Compare January 10, 2018 05:43

JPJPJPOPOP commented Jan 21, 2018

View reviewed changes

JPJPJPOPOP added 10 commits January 20, 2018 20:00

Deconflicted apertium#176

2582df3

Fix names.

70f0d63

Fix review comments.

c5ebb87

Add flow annotations.

74ca4bd

Minor fixes.

810ce86

Fix bug with known words.

63eab87

Fix wrong secondary selection.

b6abef3

Nuked secondary selector.

5c242b2

Fixed language localization.

4487627

Fix empty popover.

2c0791e

JPJPJPOPOP force-pushed the spellchecker branch from 649fb8c to 2c0791e Compare January 21, 2018 04:09

jonorthwash mentioned this pull request Feb 1, 2021

new features meta issue #390

Open

4 tasks

TinoDidriksen force-pushed the master branch from 0f5d286 to cf0ba05 Compare April 13, 2021 05:28

Conversation

JPJPJPOPOP commented Jan 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sushain97 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JPJPJPOPOP Jan 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sushain97 commented Jan 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sushain97 commented Jan 6, 2018 via email

Uh oh!

JPJPJPOPOP commented Jan 6, 2018

Uh oh!

sushain97 commented Jan 8, 2018

Uh oh!

sushain97 commented Jan 8, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sushain97 commented Jan 9, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

STSARC001 commented Mar 18, 2023

Uh oh!

Reviewers

Assignees

Labels

JPJPJPOPOP commented Jan 5, 2018 •

edited

Loading

sushain97 left a comment •

edited

Loading

JPJPJPOPOP Jan 6, 2018 •

edited

Loading

sushain97 commented Jan 6, 2018 •

edited

Loading