Skip to content

Remove the unused DeployStrategy family from the amber engine #7704

Description

@aglinxinyuan

Task Summary

The deploystrategy package — the DeployStrategy trait and its three implementations OneOnEach, RandomDeployment and RoundRobinDeployment — has had no production caller since #1807 (2023-02-02, "[Compiler Refactor 6] Refactor Amber Workflow to use the new PhysicalPlan implementation"). Searching by symbol name and by package path, the only files referencing any of the four are the package's own files and its spec.

Worker placement now happens inline. ExecutorDeployment.createWorkers picks an address directly off AddressInfo:

addressInfo.allAddresses(workerIndex % addressInfo.allAddresses.length)

which is RoundRobinDeployment's logic, absorbed into the caller. Coordinator and RegionExecutionManager reach placement through that path and never touch the trait.

Why this looks alive but is not. The package received two fixes in May 2026 — #5028 (reset the iteration cursor in OneOnEach.initialize) and #5029 (unify the empty-array errors) — plus a unit-test suite from #4723. All three came from starter-task and coverage issues (#4731, #4732, #4722) that polish the code in place; none integrates it with a caller. Every related issue and PR is closed, and nothing open proposes using the trait.

AddressInfo lives one package up and stays — it is what the live path reads.

Pure deletion, no behaviour change: −293 lines.

Task Type

  • Refactor / Cleanup

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions