Skip to content

CI: 'Check renderer architecture' wedged on main since #4246 (stale ledger) #4257

Description

@liuxiaocs7

Summary

The Check renderer architecture job (CI workflow, test) has been failing on main — and on every branch cut from it — since #4246. The committed apps/desktop/renderer-architecture.json ledger records stale metrics for three debt-tracked renderer files whose source drifted after the ledger was last regenerated in #4249, each merging without a paired ledger update.

Failing check output

Renderer architecture check failed:
- src/renderer/app-shell-chat-actions.ts: nonTriviaTokens changed; expected 4363, received 4376
- src/renderer/app-shell-session-events.ts: nonTriviaTokens changed; expected 2931, received 3042
- src/renderer/settings/import-tasks-settings-page.tsx: hookCalls changed; expected {useEffect:4,useRef:3,...}, received {useEffect:5,useRef:5,...}

Timeline

Commit PR Drift CI
9ff267510 #4249 ledger regenerated, matches source ✅ green
bdb103d59 #4246 app-shell-chat-actions.ts tokens 4363→4376 first red
838936c80 #4232 + app-shell-session-events.ts tokens 2931→3042 ❌ red
2db04c2b8 #3905 + import-tasks-settings-page.tsx hookCalls ❌ red

Each of these three PRs modified a debt-tracked renderer file without running npm run check:renderer-architecture -- --write, and their own push CI was already red — yet they still landed on main.

Fix

Regenerate the ledger snapshot so it matches the current source (--write). No runtime code changes.

Follow-up (process)

Worth investigating separately: how three PRs with a failing required test check merged into main. Consider enforcing the Check renderer architecture job as a required status check on the merge queue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions