From 5f4ed037ae691628e95560c8e71ed694f486088a Mon Sep 17 00:00:00 2001
From: abhyudayareddy <54602866+abhyudayareddy@users.noreply.github.com>
Date: Sun, 19 Apr 2026 11:04:58 -0400
Subject: [PATCH] fix(monitor): fix Redis Sentinel helpLink, sentinel metric
types, add timedout_scripts field
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Three bugs in app-redis_sentinel.yml:
1. helpLink pointed to influxdb_promql docs instead of redis_sentinel docs (copy-paste error).
2. All five sentinel section fields (sentinel_masters, sentinel_tilt, sentinel_running_scripts, sentinel_scripts_queue_length, sentinel_simulate_failure_flags) were declared as type: 1 (string) but Redis INFO sentinel returns integers for all of them. Corrected to type: 0 (number) so dashboards and alerting thresholds work correctly.
3. Added missing sentinel_timedout_scripts field (present in Redis INFO sentinel output, tracks scripts that exceeded the timeout deadline — useful for detecting runaway Lua scripts in HA pipelines).
Signed-off-by: abhyudayareddy <54602866+abhyudayareddy@users.noreply.github.com>
---
.../resources/define/app-redis_sentinel.yml | 20 ++++++++++++-------
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/hertzbeat-manager/src/main/resources/define/app-redis_sentinel.yml b/hertzbeat-manager/src/main/resources/define/app-redis_sentinel.yml
index b8f6353b016..7566f78d49f 100644
--- a/hertzbeat-manager/src/main/resources/define/app-redis_sentinel.yml
+++ b/hertzbeat-manager/src/main/resources/define/app-redis_sentinel.yml
@@ -29,8 +29,8 @@ help:
zh-TW: Hertzbeat 對 Redis Sentinel 的通用指標進行采集監控。
您可以點擊 “新建 Redis Sentinel” 並進行配置，或者選擇“更多操作”，導入已有配置。
ja-JP: Hertzbeat は Redis Sentinel の一般的なパフォーマンスのメトリクスを監視します。
「新規 Redis Sentinel」をクリックしてパラメタを設定した後、新規することができます。
helpLink:
- zh-CN: https://hertzbeat.apache.org/zh-cn/docs/help/influxdb_promql
- en-US: https://hertzbeat.apache.org/docs/help/influxdb_promql
+ zh-CN: https://hertzbeat.apache.org/zh-cn/docs/help/redis_sentinel
+ en-US: https://hertzbeat.apache.org/docs/help/redis_sentinel
# Input params define for monitoring(render web ui by the definition)
params:
# field-param field key
@@ -805,31 +805,37 @@ metrics:
fields:
# field-metric name, type-metric type(0-number,1-string), unit-metric unit('%','ms','MB'), label-whether it is a metrics label field
- field: sentinel_masters
- type: 1
+ type: 0
i18n:
zh-CN: 主节点
en-US: Masters
ja-JP: マスターノード
- field: sentinel_tilt
- type: 1
+ type: 0
i18n:
zh-CN: 倾斜
en-US: Tilt
ja-JP: マスターをダウン状態としてマークする前の待機時間
- field: sentinel_running_scripts
- type: 1
+ type: 0
i18n:
zh-CN: 运行脚本
en-US: Running Scripts
ja-JP: 実行するスクリプト
+ - field: sentinel_timedout_scripts
+ type: 0
+ i18n:
+ zh-CN: 超时脚本数
+ en-US: Timedout Scripts
+ ja-JP: タイムアウトスクリプト数
- field: sentinel_scripts_queue_length
- type: 1
+ type: 0
i18n:
zh-CN: 脚本队列长度
en-US: Scripts Queue Length
ja-JP: 実行するスクリプトのキューの長さ
- field: sentinel_simulate_failure_flags
- type: 1
+ type: 0
i18n:
zh-CN: 模拟失败标志
en-US: Simulate Failure Flags