Supress obsolete warning: Formatter-based serialization is obsolete and should not be used.

[Xpl0itR]

As an extension of #111, we should also supress SYSLIB0050

[andrewlock]

I think a better option would be to conditionally use non-obsolete APIs in those TFMs 🤔

[Xpl0itR]

Ok tell that to Microsoft...,
for example

[andrewlock]

Sorry, do you have an example of an enum that generates this error? I can't see what's obviously generating it right now 🤔

[Xpl0itR]

I did link it in my previous comment, but i can paste it here too

    [Flags]
    public enum FieldAttributes
    {
        // member access mask - Use this mask to retrieve accessibility information.
        FieldAccessMask = 0x0007,
        PrivateScope = 0x0000,    // Member not referenceable.
        Private = 0x0001,    // Accessible only by the parent type.
        FamANDAssem = 0x0002,    // Accessible by sub-types only in this Assembly.
        Assembly = 0x0003,    // Accessibly by anyone in the Assembly.
        Family = 0x0004,    // Accessible only by type and sub-types.
        FamORAssem = 0x0005,    // Accessibly by sub-types anywhere, plus anyone in assembly.
        Public = 0x0006,    // Accessibly by anyone who has visibility to this scope.
                            // end member access mask

        // field contract attributes.
        Static = 0x0010,        // Defined on type, else per instance.
        InitOnly = 0x0020,     // Field may only be initialized, not written to after init.
        Literal = 0x0040,        // Value is compile time constant.
        [Obsolete(Obsoletions.LegacyFormatterMessage, DiagnosticId = Obsoletions.LegacyFormatterDiagId, UrlFormat = Obsoletions.SharedUrlFormat)]
        NotSerialized = 0x0080,        // Field does not have to be serialized when type is remoted.

        SpecialName = 0x0200,     // field is special.  Name describes how.

        // interop attributes
        PinvokeImpl = 0x2000,        // Implementation is forwarded through pinvoke.

        RTSpecialName = 0x0400,     // Runtime(metadata internal APIs) should check name encoding.
        HasFieldMarshal = 0x1000,     // Field has marshalling information.
        HasDefault = 0x8000,     // Field has default.
        HasFieldRVA = 0x0100,     // Field has RVA.

        ReservedMask = 0x9500,
    }

[andrewlock]

oh I see what you mean, it's not really related to the code being generated, and entirely due to specific diagnostic IDs...

I'm really torn. The only solution I can see is adding 60+ #pragma warning disable SYSLIBxxxx just in case they're used on an attribute somewhere, which clearly really sucks 😕 Especially as I don't really feel like checking whether we should ignore all those...

It's ironic really that they introduced these extra IDs to make it easier to be able to ignore specific errors, but it actually makes our life harder 🙄