Skip to content

Improve NIP-29 group creator discovery reliability #nip29 #409

Description

@rabble

Problem

The useNip29GroupCreator hook has a fallback mechanism that infers the group creator from the earliest admin event, but this is not foolproof and could lead to eCash tips being sent to the wrong person if the original creator leaves the group.

Current Implementation Issues

  • Fallback assumes earliest admin = creator
  • No verification of actual group ownership
  • Could misattribute tips if creator transfers ownership
  • Limited reliability for keyless groups

Risks

  • eCash tips sent to wrong person
  • Incorrect creator attribution
  • Poor user experience for tipping

Potential Solutions

  • Implement more robust creator detection algorithms
  • Add multiple fallback strategies
  • Store creator info in group metadata when possible
  • Add user confirmation before sending tips
  • Improve error handling for ambiguous cases

Files Affected

  • Hook implementation (referenced in docs/NIP29_GROUP_CREATOR_IMPLEMENTATION.md)
  • eCash tipping components

Acceptance Criteria

  • More reliable creator detection
  • Clear user feedback when creator is uncertain
  • Confirmation dialogs for eCash transactions
  • Better error handling for edge cases

Tags: #nip29

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't workingNIP 29

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions