Ignoring duplicates from intentially redefined items

[BrknRobot]

A mod which implements compatibility with another mod may redefine portions of that mod. When that mod is included as a secondary mod, Tiger will warn about duplicate items. These can be suppressed with a duplicate-item filter, but that will remove warnings about all duplicates, not just the one intentionally created by the compatibility mod. A new type of annotation has the opportunity to make warning suppression more specific, and add additional validation for this scenario.

#tiger-redefines(mod="<secondary mod label>")

• Indicates the following definition intentionally redefines the item from the loaded secondary mod.
• duplicate-item warnings specifically referencing that mod should be suppressed.
• If this definition won't replace the referenced mod's definition (ie: this file does not come after the mod's file in the load order), warn
• If this definition doesn't replace a definition from the referenced mod, warn

#tiger-redefined-by(mod="<secondary mod label>")

• Indicates the following definition is intentionally redefined by the item from the loaded secondary mod.
• duplicate-item warnings specifically referencing that mod should be suppressed.
• If this definition won't be replaced by the referenced mod's definition (ie: this file does not come before the mod's file in the load order), warn
• If this definition isn't replaced by a definition from the referenced mod, warn

[amtep]

Hmm the first case shouldn't be a thing. Since secondary mods come before the current mod in tiger's load order, it should be considered proper for items in the mod to override those. Do you have an example of such an error?

[BrknRobot]

I don't have an example of Tiger issuing warnings for the first case. Tiger seems to be considering mod load order and file load order and not issuing warnings when the primary mods definition takes precedence. I was including both for completeness when writing the issue without really considering that the first case was probably already suppressed. That said, it would be helpful to receive warnings when I'm expecting the definition to override something and it does not (perhaps because that thing has been renamed in the base game or secondary mod). Making a change to warn on duplicate items that you are overriding is probably better suited for a strict checking option though.

Anyway, it seems that just adding a way to specify the source of the duplicate to ignore to the existing filter is probably sufficient.

[amtep]

I think the idea has merit and would help with game updates, especially if "base game" is an option along with other mods.