[VIC3/CK3] Check for Orphaned Events

[kaiser-chris]

Hi @amtep,

Events that do not have the orphan = yes property, but are not referenced/triggered anywhere are considered orphaned.

The game warns about this in the error log but Tiger does not.

This applies both to Crusader Kings 3 and Victoria 3.

Regards,

Chris

[kaiser-chris]

Not sure if CK3 has the same system but probably. I will ask in their Coop.

[kaiser-chris]

Yep CK3 has the same system.

[amtep]

Tiger traces through event triggers and marks events as "visited" while it does so, so this could be done with a second pass over the events

[amtep]

I realized that this could lead to a significant speed improvement.

Currently most events are evaluated twice, once as standalone and once as part of whatever event chain they're part of.

The standalone evaluations aren't really necessary except for orphaned events. So if we have a second phase for detecting orphaned events, we can evaluate them there and skip the evaluation in the regular validation.

[amtep]

I hit a snag while implementing this. The named scopes in scripted buttons are considered not known, and therefore events triggered from scripted buttons are not traced.

To mark them as visited, I would have to either uselessly trace them anyway, or implement some other kind of visited logic.

Or, best case, trace scripted buttons from journal entries in order to have the named scopes available.