Build improvements#4
Open
amitrahman1026 wants to merge 19 commits into
Open
Conversation
…t... not sure if this could change in future macos
… base, separator, and version.
cc::Build::try_compile uses whatever compiler the build environment provides (Clang/GCC/MSVC), respects CFLAGS, and writes to OUT_DIR without needing a temp file smoke.c references epan_get_version by address (function-to-pointer decay in C), so the compiler must see a matching declaration in the header — wrong or missing header version fails the compile
amitrahman1026
force-pushed
the
build-improvements
branch
from
fcbbe76 to
3eac4b7
Compare
ct-porco
reviewed
Apr 27, 2026
| _metadata_config: &MetadataConfig, | ||
| ) -> Result<WiresharkConfig, BuildError> { | ||
| // TODO: Should test this in CI, currently just going off what Google says | ||
| let search_configs = vec
There was a problem hiding this comment.
@amitrahman1026 This worked for me on a machine using the default Wireshark install location, but that location is not the same for every install. I think it would be better to query the registry for the Wireshark installation directory. Registry key HKCU\SOFTWARE\Microsoft\Windows\CurrentVersion\App Paths\Wireshark.exe should give the path to the per-user Wireshark install directory. Use HKLM instead of HKCU if Wireshark was installed for all users. I have access to a Windows machine to test and would be happy to put together a PR if you want.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.