Currently ATS allows for "generalized concentration"-dependent diffusivity. It does this through an input spec that makes it sound like one is providing "primary species concentration" dependent diffusivity. And indeed, users are using it like they want to provide "diffusivity of O2(aq)" when this quantity is actually "diffusivity of the corresponding generalized flux". Reported by @scottpainter.
To fix this, we need to allow evaluators to have access to both primary and secondary species concentrations. Research is required to determine what exactly needs to be done.
- in Amanzi's Alquimia PK -- how are "primary free ion concentration" and "secondary free ion concentration" dealt with? Are they always acquired from Alquimia? Only during diagnostics or every step?
- Is there an evaluator (this would be a PrimaryEvaluator, manually managed by the Alquimia_PK) associated with these quantities?
These should be updated to be done every step, and saved via an evaluator.
At this point, a user could write a diffusivity that is a function of primary concentration or secondary concentration, but would be some effective summation of the true specie-dependent diffusivity.
Then an evaluator that (first derives and then) implements the primary-and-secondary specie-based sum to get a diffusivity for the generalized specie is needed.
Currently ATS allows for "generalized concentration"-dependent diffusivity. It does this through an input spec that makes it sound like one is providing "primary species concentration" dependent diffusivity. And indeed, users are using it like they want to provide "diffusivity of O2(aq)" when this quantity is actually "diffusivity of the corresponding generalized flux". Reported by @scottpainter.
To fix this, we need to allow evaluators to have access to both primary and secondary species concentrations. Research is required to determine what exactly needs to be done.
These should be updated to be done every step, and saved via an evaluator.
At this point, a user could write a diffusivity that is a function of primary concentration or secondary concentration, but would be some effective summation of the true specie-dependent diffusivity.
Then an evaluator that (first derives and then) implements the primary-and-secondary specie-based sum to get a diffusivity for the generalized specie is needed.