From 7d8d2a40edc137e6d6bebc17e954c0cc43b65434 Mon Sep 17 00:00:00 2001 From: JoshuaCWebDeveloper Date: Thu, 4 Aug 2016 11:15:04 -0700 Subject: [PATCH 1/4] Always round hours down in toSMPTE() (fixes #2) Credit to philippede: https://github.com/allensarkisyan/VideoFrame/issues/2#issuecomment-77918912 --- VideoFrame.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/VideoFrame.js b/VideoFrame.js index 936564f..9928cc7 100644 --- a/VideoFrame.js +++ b/VideoFrame.js @@ -132,7 +132,7 @@ VideoFrame.prototype.toSMPTE = function(frame) { var fps = this.frameRate; function wrap(n) { return ((n < 10) ? '0' + n : n); } var _hour = ((fps * 60) * 60), _minute = (fps * 60); - var _hours = (frameNumber / _hour).toFixed(0); + var _hours = Math.floor(frameNumber / _hour).toFixed(0); var _minutes = (Number((frameNumber / _minute).toString().split('.')[0]) % 60); var _seconds = (Number((frameNumber / fps).toString().split('.')[0]) % 60); var SMPTE = (wrap(_hours) + ':' + wrap(_minutes) + ':' + wrap(_seconds) + ':' + wrap(frameNumber % fps)); From c9948bb4d53048d6010cb405d0be131a26079053 Mon Sep 17 00:00:00 2001 From: JoshuaCWebDeveloper Date: Thu, 4 Aug 2016 12:48:12 -0700 Subject: [PATCH 2/4] Encapsulate entire library in function to conditionally export module or global --- VideoFrame.js | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/VideoFrame.js b/VideoFrame.js index 9928cc7..c7e4037 100644 --- a/VideoFrame.js +++ b/VideoFrame.js @@ -26,6 +26,62 @@ HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTIO OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */ +// Logic for determning