From ab322fb5f9b8f54591ffd9b1bbdb9d7f8e73ea73 Mon Sep 17 00:00:00 2001 From: Tanisha Aberdeen <32620895+aliasunder@users.noreply.github.com> Date: Fri, 4 Sep 2026 19:09:30 -0400 Subject: [PATCH 1/2] feat(ship-check): carry Reviewed-at and Dismissed into the pipeline snapshot MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The phase skills report their reviewed SHA and proof-of-dismissal (PR \#9), but the orchestrator's Ship-check-complete snapshots — the report a consumer actually reads — carried neither, so the concluding verdict still couldn't distinguish a reviewed PR from an unexamined one. Both reporting templates gain the two lines: Reviewed-at (the delta-review high-water mark in default mode, the reviewed head in comment mode) and a Dismissed roll-up of the phases' dismissal lines. (umm-actually finding on PR \#9, post-merge.) Co-Authored-By: Claude Fable 5 --- plugins/ship-check/skills/ship-check/SKILL.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/plugins/ship-check/skills/ship-check/SKILL.md b/plugins/ship-check/skills/ship-check/SKILL.md index 805a46b..e3c3cf0 100644 --- a/plugins/ship-check/skills/ship-check/SKILL.md +++ b/plugins/ship-check/skills/ship-check/SKILL.md @@ -373,6 +373,7 @@ pipeline conclusion. Update it on each monitoring pass as PR status evolves. ``` Ship check complete: +- Reviewed at: - PR Review: N findings, M fixed (correctness, security, conditional) - Code Quality: N findings, M fixed (conventions, readability) - Test Audit: N findings, M fixed (test quality); K coverage gaps, J tests written @@ -380,6 +381,7 @@ Ship check complete: - Triage: N flagged findings triaged across all phases — M fixed, K deferred (L pre-existing gaps) - PR Monitor: CI status, N bot comments resolved - Deferred: +- Dismissed: N across phases (roll up the phases' proof-of-dismissal lines — or "none") - Verdict: ship / ship-with-minor-fixes / needs-changes ``` @@ -395,6 +397,7 @@ Output the final summary after Phase 4 completes — this is the pipeline conclu ``` Ship check complete (comment mode): +- Reviewed at: - PR Review: N findings commented (correctness, security, conditional) - Code Quality: N findings commented (conventions, readability) - Test Audit: N findings commented (test quality); K coverage gaps reported @@ -402,6 +405,7 @@ Ship check complete (comment mode): - Triage: N flagged findings triaged across all phases — M commented, K deferred - PR Monitor: skipped (comment mode) - Deferred: +- Dismissed: N across phases (roll up the phases' proof-of-dismissal lines — or "none") - Verdict: ship / ship-with-minor-fixes / needs-changes - Reviews posted: N (one per phase with findings) ``` From 81ac7e5ca72d42ab6a693d62ec8e8848f1903b97 Mon Sep 17 00:00:00 2001 From: Tanisha Aberdeen <32620895+aliasunder@users.noreply.github.com> Date: Fri, 4 Sep 2026 19:14:31 -0400 Subject: [PATCH 2/2] fix(ship-check): comment-mode Reviewed-at must not assume one head SHA MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Phases run sequentially in comment mode and the head can move between dispatches, so a single reported SHA overstates what earlier phases saw. Reworded to the Phase 4 completion head with per-phase SHAs when the head moved — each phase already reports its own. (umm-actually finding on PR \#10.) Co-Authored-By: Claude Fable 5 --- plugins/ship-check/skills/ship-check/SKILL.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/ship-check/skills/ship-check/SKILL.md b/plugins/ship-check/skills/ship-check/SKILL.md index e3c3cf0..463a7a6 100644 --- a/plugins/ship-check/skills/ship-check/SKILL.md +++ b/plugins/ship-check/skills/ship-check/SKILL.md @@ -397,7 +397,7 @@ Output the final summary after Phase 4 completes — this is the pipeline conclu ``` Ship check complete (comment mode): -- Reviewed at: +- Reviewed at: - PR Review: N findings commented (correctness, security, conditional) - Code Quality: N findings commented (conventions, readability) - Test Audit: N findings commented (test quality); K coverage gaps reported