From d093aebc8ea377623ebb478ef343404ee28934f5 Mon Sep 17 00:00:00 2001 From: stdavis Date: Wed, 18 Feb 2026 11:35:09 -0700 Subject: [PATCH 1/4] chore: remove deprecated recommended extension --- .vscode/extensions.json | 1 - 1 file changed, 1 deletion(-) diff --git a/.vscode/extensions.json b/.vscode/extensions.json index cd80e0d..8f95738 100644 --- a/.vscode/extensions.json +++ b/.vscode/extensions.json @@ -7,7 +7,6 @@ "njpwerner.autodocstring", "ms-python.vscode-pylance", "ms-python.python", - "donjayamanne.python-environment-manager", "charliermarsh.ruff", "tamasfe.even-better-toml" ], From 98bbba3c1c7f46c0df1eb4b4667e5f296bde0e5a Mon Sep 17 00:00:00 2001 From: stdavis Date: Wed, 18 Feb 2026 11:40:59 -0700 Subject: [PATCH 2/4] chore: fix unit test This happened with there was a find replace from steveoh to stdavis --- .vscode/settings.json | 5 ++++- tests/test_task_checker.py | 5 ++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index 4643dd5..e53f705 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -65,5 +65,8 @@ "[python]": { "editor.defaultFormatter": "charliermarsh.ruff", "editor.formatOnSave": true - } + }, + "python-envs.defaultEnvManager": "ms-python.python:conda", + "python-envs.defaultPackageManager": "ms-python.python:conda", + "python-envs.pythonProjects": [] } diff --git a/tests/test_task_checker.py b/tests/test_task_checker.py index 27c41e1..5ce6515 100644 --- a/tests/test_task_checker.py +++ b/tests/test_task_checker.py @@ -20,12 +20,11 @@ def test_get_users_task_statuses(): tasks = get_users_task_statuses(body_mocks["simple"]) - assert len(tasks) == 4 + assert len(tasks) == 3 assert tasks == [ ("@gregbunce", 1, 1), - ("@stdavis", 3, 1), + ("@stdavis", 4, 1), ("@rkelson", 1, 0), - ("@stdavis", 1, 0), ] tasks = get_users_task_statuses(body_mocks["strikethrough"]) From f0abdf0662b46f5155bec5e76af706711b1a57e5 Mon Sep 17 00:00:00 2001 From: stdavis Date: Wed, 18 Feb 2026 11:43:53 -0700 Subject: [PATCH 3/4] ci: trigger PR checks on changes to tests --- .github/workflows/pull_request.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index cedd243..36c0136 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -4,6 +4,7 @@ on: pull_request: paths: - "src/conductor/**" + - "tests/**" - ".github/workflows/*.yml" - "setup.py" From 2b5e945eeb549d1d312d4f1da9df9194010870f3 Mon Sep 17 00:00:00 2001 From: stdavis Date: Wed, 18 Feb 2026 11:47:27 -0700 Subject: [PATCH 4/4] chore: address copilot feedback --- .vscode/settings.json | 5 +---- tests/test_task_checker.py | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index e53f705..4643dd5 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -65,8 +65,5 @@ "[python]": { "editor.defaultFormatter": "charliermarsh.ruff", "editor.formatOnSave": true - }, - "python-envs.defaultEnvManager": "ms-python.python:conda", - "python-envs.defaultPackageManager": "ms-python.python:conda", - "python-envs.pythonProjects": [] + } } diff --git a/tests/test_task_checker.py b/tests/test_task_checker.py index 5ce6515..db02a13 100644 --- a/tests/test_task_checker.py +++ b/tests/test_task_checker.py @@ -20,7 +20,6 @@ def test_get_users_task_statuses(): tasks = get_users_task_statuses(body_mocks["simple"]) - assert len(tasks) == 3 assert tasks == [ ("@gregbunce", 1, 1), ("@stdavis", 4, 1),