From e952068fd6bf9b0bcc29bc4b25822c9b9674080b Mon Sep 17 00:00:00 2001 From: stoffu Date: Tue, 20 Dec 2022 13:15:41 +0900 Subject: [PATCH 1/2] unit_tests: remove AddressFromURL.Success test (with URL=donate.aeon.cash) --- tests/unit_tests/address_from_url.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/unit_tests/address_from_url.cpp b/tests/unit_tests/address_from_url.cpp index e5e486a2211..5138ebcabc8 100644 --- a/tests/unit_tests/address_from_url.cpp +++ b/tests/unit_tests/address_from_url.cpp @@ -82,6 +82,7 @@ TEST(AddressFromTXT, Failure) ASSERT_STREQ("", res.c_str()); } +#if 0 TEST(AddressFromURL, Success) { const std::string addr = AEON_DONATION_ADDR; @@ -104,6 +105,7 @@ TEST(AddressFromURL, Success) EXPECT_STREQ(addr.c_str(), addresses[0].c_str()); } } +#endif TEST(AddressFromURL, Failure) { From 17568c0958a76b83323f26b096eea0bbc565fdc6 Mon Sep 17 00:00:00 2001 From: stoffu Date: Tue, 20 Dec 2022 15:40:59 +0900 Subject: [PATCH 2/2] unit_tests.AddressFromURL.Failure: fixed seemingly wrong assertion --- tests/unit_tests/address_from_url.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit_tests/address_from_url.cpp b/tests/unit_tests/address_from_url.cpp index 5138ebcabc8..15d62907bc4 100644 --- a/tests/unit_tests/address_from_url.cpp +++ b/tests/unit_tests/address_from_url.cpp @@ -114,7 +114,7 @@ TEST(AddressFromURL, Failure) std::vector addresses = tools::dns_utils::addresses_from_url("example.veryinvalid", dnssec_result); // for a non-existing domain such as "example.invalid", the non-existence is proved with NSEC records - ASSERT_TRUE(dnssec_result); + ASSERT_FALSE(dnssec_result); ASSERT_EQ(0, addresses.size()); }