Skip to content

Commit df0ba7a

Browse files
V48 Gate 3: remove OTF feature — telemetry source + API/storage/ORM + instruction UI
Completes the OTF removal. Telemetry-type source (the earlier commit only captured the test deletion; its source edits land here): stream-parser cases, ParsedStreamData fields, pipeline-execution-log TYPE_STYLES/heuristics/case + ChatBubbleIcon import, tailwind otf colors, mock union. API/storage/ORM/UI (executed + verified by subagent): deleted the instructions API route, the ExecutionsInstructions submit UI (+ alias + Fixed variant + RunInstructions stories), and the OTF API tests; removed fetchShippableInstructions/postShippableInstruction (api-client), the ExecutionsPageClient instruction block, the AssetPackRunInstructionsModel + run_otf_instructions ORM model/types/exports/client-accessors/data-health/refresh-schema, the edgetimes unresolved-table entry, and OTF story sample data. orm + uapi + asset-pack tsc 0 errors; orm 21 tests pass. Deferred to a deliberate DB step: DROP the deliverable_pipeline_otf_instructions/run_otf_instructions table (migration) — generated DB types + tracked compiled .js mirrors (api-client.js, protocol proven-generator.js) still mirror the live schema and regenerate after the drop. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent f581774 commit df0ba7a

29 files changed

Lines changed: 8 additions & 927 deletions

packages/orm/scripts/refresh-schema-types.ts

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -246,36 +246,6 @@ const STORAGE_COMPATIBILITY_TABLES = ` executions: {
246246
}
247247
Relationships: []
248248
}
249-
run_otf_instructions: {
250-
Row: {
251-
created_at: string | null
252-
id: string
253-
instruction_data: Json
254-
instruction_type: string
255-
is_processed: boolean | null
256-
processed_at: string | null
257-
run_id: string
258-
}
259-
Insert: {
260-
created_at?: string | null
261-
id?: string
262-
instruction_data: Json
263-
instruction_type: string
264-
is_processed?: boolean | null
265-
processed_at?: string | null
266-
run_id: string
267-
}
268-
Update: {
269-
created_at?: string | null
270-
id?: string
271-
instruction_data?: Json
272-
instruction_type?: string
273-
is_processed?: boolean | null
274-
processed_at?: string | null
275-
run_id?: string
276-
}
277-
Relationships: []
278-
}
279249
`;
280250

281251
const ORM_HELPERS = `

packages/orm/src/__tests__/bitcode-execution-storage.test.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import {
22
AssetPackGeneratedAssetsModel,
33
AssetPackPhaseExecutionsModel,
4-
AssetPackRunInstructionsModel,
54
AssetPackRunJobsModel,
65
AssetPackStreamLogsModel,
76
AssetPackVectorsModel,
@@ -47,7 +46,6 @@ describe('Bitcode execution storage ORM parity', () => {
4746
assetPackPhaseExecutions: 'phase_executions',
4847
assetPackVectors: 'deliverable_vectors',
4948
run_jobs: 'run_jobs',
50-
run_otf_instructions: 'run_otf_instructions',
5149
stream_logs: 'stream_logs',
5250
generated_assets: 'generated_assets',
5351
events: 'events',
@@ -59,7 +57,6 @@ describe('Bitcode execution storage ORM parity', () => {
5957
it.each([
6058
[AssetPackVectorsModel, 'deliverable_vectors', 'listByAssetPackEvidenceId', ['deliverable_id', 'asset-pack-1']],
6159
[AssetPackPhaseExecutionsModel, 'phase_executions', 'listByRunId', ['run_id', 'run-1']],
62-
[AssetPackRunInstructionsModel, 'run_otf_instructions', 'listByRunId', ['run_id', 'run-1']],
6360
[AssetPackGeneratedAssetsModel, 'generated_assets', 'listByRunId', ['run_id', 'run-1']],
6461
[AssetPackStreamLogsModel, 'stream_logs', 'listByStreamId', ['stream_id', 'stream-1']],
6562
[BitcodeActivityEventsModel, 'events', 'listByUserId', ['user_id', 'user-1']],

packages/orm/src/client.d.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import { MessageAttachmentsModel } from './models/message-attachments';
1515
import { UserConnectionsModel } from './models/user-connections';
1616
import { UserBtdBalancesModel } from './models/user-btd-balances';
1717
import { BtdRegistryModel } from './models/btd-registry';
18-
import { AssetPackGeneratedAssetsModel, AssetPackPhaseExecutionsModel, AssetPackRunInstructionsModel, AssetPackRunJobsModel, AssetPackStreamLogsModel, AssetPackVectorsModel, BitcodeActivityEventsModel, BitcodeErrorLogsModel, BitcodeTokenCostsModel } from './models/bitcode-execution-storage';
18+
import { AssetPackGeneratedAssetsModel, AssetPackPhaseExecutionsModel, AssetPackRunJobsModel, AssetPackStreamLogsModel, AssetPackVectorsModel, BitcodeActivityEventsModel, BitcodeErrorLogsModel, BitcodeTokenCostsModel } from './models/bitcode-execution-storage';
1919
/**
2020
* Standard client interface
2121
*/
@@ -30,7 +30,6 @@ export interface BitcodeOrmClient {
3030
assetPackVectors: AssetPackVectorsModel;
3131
assetPackPhaseExecutions: AssetPackPhaseExecutionsModel;
3232
assetPackRunJobs: AssetPackRunJobsModel;
33-
assetPackRunInstructions: AssetPackRunInstructionsModel;
3433
assetPackStreamLogs: AssetPackStreamLogsModel;
3534
assetPackGeneratedAssets: AssetPackGeneratedAssetsModel;
3635
bitcodeActivityEvents: BitcodeActivityEventsModel;

packages/orm/src/client.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import { BtdRegistryModel } from './models/btd-registry';
2121
import {
2222
AssetPackGeneratedAssetsModel,
2323
AssetPackPhaseExecutionsModel,
24-
AssetPackRunInstructionsModel,
2524
AssetPackRunJobsModel,
2625
AssetPackStreamLogsModel,
2726
AssetPackVectorsModel,
@@ -95,7 +94,6 @@ export interface BitcodeOrmClient {
9594
assetPackVectors: AssetPackVectorsModel;
9695
assetPackPhaseExecutions: AssetPackPhaseExecutionsModel;
9796
assetPackRunJobs: AssetPackRunJobsModel;
98-
assetPackRunInstructions: AssetPackRunInstructionsModel;
9997
assetPackStreamLogs: AssetPackStreamLogsModel;
10098
assetPackGeneratedAssets: AssetPackGeneratedAssetsModel;
10199
bitcodeActivityEvents: BitcodeActivityEventsModel;
@@ -144,7 +142,6 @@ export function createClient(authToken?: string): BitcodeOrmClient {
144142
assetPackVectors: new AssetPackVectorsModel(supabase),
145143
assetPackPhaseExecutions: new AssetPackPhaseExecutionsModel(supabase),
146144
assetPackRunJobs: new AssetPackRunJobsModel(supabase),
147-
assetPackRunInstructions: new AssetPackRunInstructionsModel(supabase),
148145
assetPackStreamLogs: new AssetPackStreamLogsModel(supabase),
149146
assetPackGeneratedAssets: new AssetPackGeneratedAssetsModel(supabase),
150147
bitcodeActivityEvents: new BitcodeActivityEventsModel(supabase),
@@ -184,7 +181,6 @@ export function createAdminClient(): AdminClient {
184181
assetPackVectors: new AssetPackVectorsModel(supabase),
185182
assetPackPhaseExecutions: new AssetPackPhaseExecutionsModel(supabase),
186183
assetPackRunJobs: new AssetPackRunJobsModel(supabase),
187-
assetPackRunInstructions: new AssetPackRunInstructionsModel(supabase),
188184
assetPackStreamLogs: new AssetPackStreamLogsModel(supabase),
189185
assetPackGeneratedAssets: new AssetPackGeneratedAssetsModel(supabase),
190186
bitcodeActivityEvents: new BitcodeActivityEventsModel(supabase),

packages/orm/src/data-health/checks.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ export const CANONICAL_APPLICATION_TABLES = [
4444
'deliverable_pipeline_phase_delegations',
4545
'deliverable_pipeline_agent_steps',
4646
'deliverable_pipeline_generations',
47-
'deliverable_pipeline_otf_instructions',
4847
'deliverable_pipeline_substeps',
4948
'deliverable_pipeline_tool_executions',
5049
'error_logs',

packages/orm/src/index.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export { BtdRegistryModel } from './models/btd-registry';
2424
export type { BtdRegistryInsertResult, BtdRegistryTable } from './models/btd-registry';
2525
export { AssetPackEvidenceModel } from './models/asset-pack-evidence';
2626
export type { AssetPackEvidenceRecord } from './models/asset-pack-evidence';
27-
export { AssetPackGeneratedAssetsModel, AssetPackPhaseExecutionsModel, AssetPackRunInstructionsModel, AssetPackRunJobsModel, AssetPackStreamLogsModel, AssetPackVectorsModel, BITCODE_EXECUTION_STORAGE_SCHEMA_PARITY, BitcodeActivityEventsModel, BitcodeErrorLogsModel, BitcodeTokenCostsModel, } from './models/bitcode-execution-storage';
27+
export { AssetPackGeneratedAssetsModel, AssetPackPhaseExecutionsModel, AssetPackRunJobsModel, AssetPackStreamLogsModel, AssetPackVectorsModel, BITCODE_EXECUTION_STORAGE_SCHEMA_PARITY, BitcodeActivityEventsModel, BitcodeErrorLogsModel, BitcodeTokenCostsModel, } from './models/bitcode-execution-storage';
2828
export { PipelineExecutionsModel } from './models/pipeline-executions';
2929
export { ExecutionEventsModel } from './models/execution-events';
3030
export { NotificationsModel } from './models/notifications';
@@ -48,7 +48,7 @@ export type MessageAttachment = Tables<'message_attachments'>;
4848
export { hydrateBitcodeProfile, mergeBitcodeProfileSettings, profileHasWalletBinding, profileHasVerifiedWalletBinding, readBitcodeProfileSettings, readBitcodeWalletCapabilityFromProfile, readBitcodeWalletBindingFromProfile, } from './profile-contract';
4949
export type { BitcodeProfileSettings, BitcodeWalletCapability, BitcodeWalletBinding, BitcodeWalletBindingStatus, HydratedBitcodeProfileFields, } from './profile-contract';
5050
export type PhaseExecution = Tables<'phase_executions'>;
51-
export type { AssetPackGeneratedAsset, AssetPackGeneratedAssetInsert, AssetPackGeneratedAssetUpdate, AssetPackPhaseExecution, AssetPackPhaseExecutionInsert, AssetPackPhaseExecutionUpdate, AssetPackRunInstruction, AssetPackRunInstructionInsert, AssetPackRunInstructionUpdate, AssetPackRunJob, AssetPackRunJobInsert, AssetPackRunJobUpdate, AssetPackStreamLog, AssetPackStreamLogInsert, AssetPackStreamLogUpdate, AssetPackVector, AssetPackVectorInsert, AssetPackVectorUpdate, BitcodeActivityEvent, BitcodeActivityEventInsert, BitcodeActivityEventUpdate, BitcodeErrorLog, BitcodeErrorLogInsert, BitcodeErrorLogUpdate, BitcodeTokenCost, BitcodeTokenCostInsert, BitcodeTokenCostUpdate, } from './models/bitcode-execution-storage';
51+
export type { AssetPackGeneratedAsset, AssetPackGeneratedAssetInsert, AssetPackGeneratedAssetUpdate, AssetPackPhaseExecution, AssetPackPhaseExecutionInsert, AssetPackPhaseExecutionUpdate, AssetPackRunJob, AssetPackRunJobInsert, AssetPackRunJobUpdate, AssetPackStreamLog, AssetPackStreamLogInsert, AssetPackStreamLogUpdate, AssetPackVector, AssetPackVectorInsert, AssetPackVectorUpdate, BitcodeActivityEvent, BitcodeActivityEventInsert, BitcodeActivityEventUpdate, BitcodeErrorLog, BitcodeErrorLogInsert, BitcodeErrorLogUpdate, BitcodeTokenCost, BitcodeTokenCostInsert, BitcodeTokenCostUpdate, } from './models/bitcode-execution-storage';
5252
export { ConversationsModel } from './models/conversations';
5353
export { MessagesModel } from './models/messages';
5454
export { UsersModel } from './models/users';

packages/orm/src/index.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ export type { AssetPackEvidenceRecord } from './models/asset-pack-evidence';
3636
export {
3737
AssetPackGeneratedAssetsModel,
3838
AssetPackPhaseExecutionsModel,
39-
AssetPackRunInstructionsModel,
4039
AssetPackRunJobsModel,
4140
AssetPackStreamLogsModel,
4241
AssetPackVectorsModel,
@@ -113,9 +112,6 @@ export type {
113112
AssetPackPhaseExecution,
114113
AssetPackPhaseExecutionInsert,
115114
AssetPackPhaseExecutionUpdate,
116-
AssetPackRunInstruction,
117-
AssetPackRunInstructionInsert,
118-
AssetPackRunInstructionUpdate,
119115
AssetPackRunJob,
120116
AssetPackRunJobInsert,
121117
AssetPackRunJobUpdate,

packages/orm/src/models/bitcode-execution-storage.d.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ export declare const BITCODE_EXECUTION_STORAGE_SCHEMA_PARITY: {
55
readonly assetPackPhaseExecutions: "phase_executions";
66
readonly assetPackVectors: "deliverable_vectors";
77
readonly run_jobs: "run_jobs";
8-
readonly run_otf_instructions: "run_otf_instructions";
98
readonly stream_logs: "stream_logs";
109
readonly generated_assets: "generated_assets";
1110
readonly events: "events";
@@ -21,9 +20,6 @@ export type AssetPackPhaseExecutionUpdate = Updatable<'phase_executions'>;
2120
export type AssetPackRunJob = Tables<'run_jobs'>;
2221
export type AssetPackRunJobInsert = Insertable<'run_jobs'>;
2322
export type AssetPackRunJobUpdate = Updatable<'run_jobs'>;
24-
export type AssetPackRunInstruction = Tables<'run_otf_instructions'>;
25-
export type AssetPackRunInstructionInsert = Insertable<'run_otf_instructions'>;
26-
export type AssetPackRunInstructionUpdate = Updatable<'run_otf_instructions'>;
2723
export type AssetPackStreamLog = Tables<'stream_logs'>;
2824
export type AssetPackStreamLogInsert = Insertable<'stream_logs'>;
2925
export type AssetPackStreamLogUpdate = Updatable<'stream_logs'>;
@@ -39,7 +35,7 @@ export type BitcodeErrorLogUpdate = Updatable<'error_logs'>;
3935
export type BitcodeTokenCost = Tables<'token_costs'>;
4036
export type BitcodeTokenCostInsert = Insertable<'token_costs'>;
4137
export type BitcodeTokenCostUpdate = Updatable<'token_costs'>;
42-
type RunScopedTable = 'phase_executions' | 'run_otf_instructions' | 'generated_assets' | 'token_costs';
38+
type RunScopedTable = 'phase_executions' | 'generated_assets' | 'token_costs';
4339
declare abstract class RunScopedModel<T extends RunScopedTable> extends BaseModel<T> {
4440
listByRunId(runId: string, options?: {
4541
limit?: number;
@@ -85,9 +81,6 @@ export declare class AssetPackRunJobsModel extends BaseModel<'run_jobs'> {
8581
updated_at: string | null;
8682
}[]>;
8783
}
88-
export declare class AssetPackRunInstructionsModel extends RunScopedModel<'run_otf_instructions'> {
89-
constructor(supabase: SupabaseClient<Database>);
90-
}
9184
export declare class AssetPackStreamLogsModel extends UserScopedModel<'stream_logs'> {
9285
constructor(supabase: SupabaseClient<Database>);
9386
listByStreamId(streamId: string, options?: {

packages/orm/src/models/bitcode-execution-storage.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ export const BITCODE_EXECUTION_STORAGE_SCHEMA_PARITY = {
66
assetPackPhaseExecutions: 'phase_executions',
77
assetPackVectors: 'deliverable_vectors',
88
run_jobs: 'run_jobs',
9-
run_otf_instructions: 'run_otf_instructions',
109
stream_logs: 'stream_logs',
1110
generated_assets: 'generated_assets',
1211
events: 'events',
@@ -26,10 +25,6 @@ export type AssetPackRunJob = Tables<'run_jobs'>;
2625
export type AssetPackRunJobInsert = Insertable<'run_jobs'>;
2726
export type AssetPackRunJobUpdate = Updatable<'run_jobs'>;
2827

29-
export type AssetPackRunInstruction = Tables<'run_otf_instructions'>;
30-
export type AssetPackRunInstructionInsert = Insertable<'run_otf_instructions'>;
31-
export type AssetPackRunInstructionUpdate = Updatable<'run_otf_instructions'>;
32-
3328
export type AssetPackStreamLog = Tables<'stream_logs'>;
3429
export type AssetPackStreamLogInsert = Insertable<'stream_logs'>;
3530
export type AssetPackStreamLogUpdate = Updatable<'stream_logs'>;
@@ -52,7 +47,6 @@ export type BitcodeTokenCostUpdate = Updatable<'token_costs'>;
5247

5348
type RunScopedTable =
5449
| 'phase_executions'
55-
| 'run_otf_instructions'
5650
| 'generated_assets'
5751
| 'token_costs';
5852

@@ -139,12 +133,6 @@ export class AssetPackRunJobsModel extends BaseModel<'run_jobs'> {
139133
}
140134
}
141135

142-
export class AssetPackRunInstructionsModel extends RunScopedModel<'run_otf_instructions'> {
143-
constructor(supabase: SupabaseClient<Database>) {
144-
super(supabase, 'run_otf_instructions');
145-
}
146-
}
147-
148136
export class AssetPackStreamLogsModel extends UserScopedModel<'stream_logs'> {
149137
constructor(supabase: SupabaseClient<Database>) {
150138
super(supabase, 'stream_logs');

packages/orm/src/models/index.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ export { ExecutionEventsModel } from './execution-events';
2323
export {
2424
AssetPackGeneratedAssetsModel,
2525
AssetPackPhaseExecutionsModel,
26-
AssetPackRunInstructionsModel,
2726
AssetPackRunJobsModel,
2827
AssetPackStreamLogsModel,
2928
AssetPackVectorsModel,
@@ -101,9 +100,6 @@ export type {
101100
AssetPackPhaseExecution,
102101
AssetPackPhaseExecutionInsert,
103102
AssetPackPhaseExecutionUpdate,
104-
AssetPackRunInstruction,
105-
AssetPackRunInstructionInsert,
106-
AssetPackRunInstructionUpdate,
107103
AssetPackRunJob,
108104
AssetPackRunJobInsert,
109105
AssetPackRunJobUpdate,

0 commit comments

Comments
 (0)