Skip to content

Commit d9816f2

Browse files
geraldarthurdavisgeraldarthurdavis
committed
V43 Gate 3: Align public shell Packs tests
Moves the footer Packs link to the canonical /packs route, refreshes stale public shell and route-model assertions, and regenerates the route vocabulary inventory after the Exchange compatibility surface became a redirect.
1 parent 1c7378e commit d9816f2

5 files changed

Lines changed: 36 additions & 40 deletions

File tree

‎.bitcode/v43-route-vocabulary-inventory.json‎

Lines changed: 19 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"currentTarget": "V42",
66
"sourceSafetyVerdict": "source-safe-route-vocabulary-inventory-metadata",
77
"generatedAt": "deterministic",
8-
"artifactRoot": "v43-route-vocabulary-inventory:f0087be9e1d1057116bc0eaf",
8+
"artifactRoot": "v43-route-vocabulary-inventory:b688a0d8808d69db7a52e9a3",
99
"passed": true,
1010
"tokenIds": [
1111
"route:/exchange",
@@ -12785,20 +12785,19 @@
1278512785
},
1278612786
{
1278712787
"path": "uapi/components/base/bitcode/layout/footer.tsx",
12788-
"pathRoot": "v43-route-vocabulary-file:cc92b129b2ef4dc4925b0312",
12788+
"pathRoot": "v43-route-vocabulary-file:3000d2c67388973f3286435f",
1278912789
"categories": [
1279012790
"component",
1279112791
"telemetry"
1279212792
],
1279312793
"tokenCounts": {
12794-
"route:/exchange": 1,
1279512794
"route:/terminal": 1,
12796-
"symbol:Exchange": 2,
12795+
"route:/packs": 1,
1279712796
"symbol:Terminal": 2,
12798-
"word:exchange": 4,
12797+
"symbol:Packs": 1,
1279912798
"word:terminal": 3
1280012799
},
12801-
"totalMatches": 13,
12800+
"totalMatches": 8,
1280212801
"sourceSafeMetadataOnly": true,
1280312802
"rawSourceTextSerialized": false,
1280412803
"sourceSnippetSerialized": false
@@ -14029,21 +14028,20 @@
1402914028
},
1403014029
{
1403114030
"path": "uapi/tests/footerPublicShell.test.tsx",
14032-
"pathRoot": "v43-route-vocabulary-file:b9625dfc49f69c345eb19068",
14031+
"pathRoot": "v43-route-vocabulary-file:edb631b94192c2da190f6ee3",
1403314032
"categories": [
1403414033
"component",
1403514034
"telemetry",
1403614035
"test"
1403714036
],
1403814037
"tokenCounts": {
14039-
"route:/exchange": 1,
1404014038
"route:/terminal": 1,
14041-
"symbol:Exchange": 2,
14039+
"route:/packs": 1,
1404214040
"symbol:Terminal": 3,
14043-
"word:exchange": 2,
14041+
"symbol:Packs": 2,
1404414042
"word:terminal": 1
1404514043
},
14046-
"totalMatches": 10,
14044+
"totalMatches": 8,
1404714045
"sourceSafeMetadataOnly": true,
1404814046
"rawSourceTextSerialized": false,
1404914047
"sourceSnippetSerialized": false
@@ -14086,17 +14084,16 @@
1408614084
},
1408714085
{
1408814086
"path": "uapi/tests/navBrand.test.tsx",
14089-
"pathRoot": "v43-route-vocabulary-file:053989f7acfb4c52cc6ed7b8",
14087+
"pathRoot": "v43-route-vocabulary-file:909e5a7aa8fcea65cf7d3436",
1409014088
"categories": [
1409114089
"component",
1409214090
"telemetry",
1409314091
"test"
1409414092
],
1409514093
"tokenCounts": {
14096-
"word:exchange": 3,
1409714094
"word:terminal": 3
1409814095
},
14099-
"totalMatches": 6,
14096+
"totalMatches": 3,
1410014097
"sourceSafeMetadataOnly": true,
1410114098
"rawSourceTextSerialized": false,
1410214099
"sourceSnippetSerialized": false
@@ -15078,18 +15075,17 @@
1507815075
},
1507915076
{
1508015077
"path": "uapi/tests/terminalTransactionReadModel.test.ts",
15081-
"pathRoot": "v43-route-vocabulary-file:5588995ff7388208b7b61a5a",
15078+
"pathRoot": "v43-route-vocabulary-file:685b8965132c3620372c151e",
1508215079
"categories": [
1508315080
"telemetry",
1508415081
"test"
1508515082
],
1508615083
"tokenCounts": {
15087-
"route:/exchange": 1,
1508815084
"route:/terminal": 4,
15089-
"word:exchange": 1,
15085+
"route:/packs": 1,
1509015086
"word:terminal": 8
1509115087
},
15092-
"totalMatches": 14,
15088+
"totalMatches": 13,
1509315089
"sourceSafeMetadataOnly": true,
1509415090
"rawSourceTextSerialized": false,
1509515091
"sourceSnippetSerialized": false
@@ -15257,19 +15253,19 @@
1525715253
"coverage": {
1525815254
"sourceFileCount": 897,
1525915255
"tokenTotals": {
15260-
"route:/exchange": 150,
15256+
"route:/exchange": 147,
1526115257
"route:/terminal": 1435,
15262-
"route:/packs": 148,
15258+
"route:/packs": 151,
1526315259
"route:/read": 242,
1526415260
"route:/deposit": 84,
15265-
"symbol:Exchange": 1968,
15261+
"symbol:Exchange": 1964,
1526615262
"symbol:Terminal": 3092,
15267-
"symbol:Packs": 48,
15263+
"symbol:Packs": 51,
1526815264
"symbol:Reading": 1288,
1526915265
"symbol:Depositing": 234,
1527015266
"symbol:PackActivity": 28,
1527115267
"symbol:DepositAssetPackOption": 12,
15272-
"word:exchange": 1718,
15268+
"word:exchange": 1708,
1527315269
"word:terminal": 3655,
1527415270
"word:self-referential": 30
1527515271
},

‎uapi/components/base/bitcode/layout/footer.tsx‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,14 @@ import { DisabledTooltipWrapper } from '@/components/base/bitcode/overlays/disab
2323
import { BITCODE_GITHUB_APP_PUBLIC_URL } from '@/lib/github-app-url';
2424

2525
const TERMINAL_URL = '/terminal';
26-
const EXCHANGE_URL = '/exchange';
26+
const PACKS_URL = '/packs';
2727
const DEFAULT_OPERATOR_GUIDE_URL =
2828
process.env.NEXT_PUBLIC_BITCODE_OPERATOR_GUIDE_URL?.trim() || '/docs';
2929
const CURRENT_PROTOCOL_SPEC_URL = 'https://github.com/engineeredsoftware/ENGI/blob/main/BITCODE_SPEC.txt';
3030
const BITCODE_REPOSITORY_URL = 'https://github.com/engineeredsoftware/bitcode';
3131
const DISABLED_FEATURE_TOOLTIPS = {
32-
exchange:
33-
'Disabled for launch mode. When enabled, Exchange opens the public Source Shares activity and market-reading surface.',
32+
packs:
33+
'Disabled for launch mode. When enabled, Packs opens the public Source Shares activity and pack-reading surface.',
3434
terminal:
3535
'Disabled for launch mode. When enabled, Terminal opens the full deposit-to-settle ledger, proofs, and history workspace.',
3636
auxillaries:
@@ -121,10 +121,10 @@ export default function Footer({ showPrimaryContent = true, className = '' }: Fo
121121
: BITCODE_PUBLIC_COPY.footer.guestCta;
122122
const footerLinks = useMemo(() => [
123123
{
124-
ariaLabel: 'Exchange',
124+
ariaLabel: BITCODE_PUBLIC_COPY.footer.links.network,
125125
label: BITCODE_PUBLIC_COPY.footer.links.network,
126-
meta: 'Public exchange',
127-
href: EXCHANGE_URL,
126+
meta: 'Pack activity',
127+
href: PACKS_URL,
128128
explainer: BITCODE_PUBLIC_EXPLAINERS.network,
129129
icon: (
130130
<span
@@ -237,7 +237,7 @@ export default function Footer({ showPrimaryContent = true, className = '' }: Fo
237237
], []);
238238
const isExternalHref = (href: string) => href.startsWith('http');
239239
const disableAuxillaries = Boolean(FEATURE_FLAGS.DISABLE_AUXILLARIES);
240-
const disableExchangeLink = Boolean(FEATURE_FLAGS.DISABLE_EXCHANGE_LINK);
240+
const disablePacksLink = Boolean(FEATURE_FLAGS.DISABLE_EXCHANGE_LINK);
241241
const disableTerminalLink = Boolean(FEATURE_FLAGS.DISABLE_TERMINAL_LINK);
242242

243243
return (
@@ -374,7 +374,7 @@ export default function Footer({ showPrimaryContent = true, className = '' }: Fo
374374
<div className="grid w-full grid-cols-1 gap-2 phone:grid-cols-2 laptop:grid-cols-[repeat(4,minmax(0,1fr))]">
375375
{footerLinks.map((social) => {
376376
const isDisabledRoute =
377-
(social.href === EXCHANGE_URL && disableExchangeLink) ||
377+
(social.href === PACKS_URL && disablePacksLink) ||
378378
(social.href === TERMINAL_URL && disableTerminalLink);
379379
const explainerButton = social.explainer ? (
380380
<BitcodeInlineExplainer
@@ -405,8 +405,8 @@ export default function Footer({ showPrimaryContent = true, className = '' }: Fo
405405
<span key={social.ariaLabel} className="block w-full">
406406
<DisabledTooltipWrapper
407407
tooltip={
408-
social.href === EXCHANGE_URL
409-
? DISABLED_FEATURE_TOOLTIPS.exchange
408+
social.href === PACKS_URL
409+
? DISABLED_FEATURE_TOOLTIPS.packs
410410
: DISABLED_FEATURE_TOOLTIPS.terminal
411411
}
412412
className="w-full"

‎uapi/tests/footerPublicShell.test.tsx‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@ describe('Footer public shell', () => {
5151
it('renders third-gate public labels and opens orbitals access for guests', () => {
5252
render(<Footer />);
5353

54-
expect(screen.getByRole('link', { name: 'Exchange' })).toHaveAttribute(
54+
expect(screen.getByRole('link', { name: 'Packs' })).toHaveAttribute(
5555
'href',
56-
'/exchange',
56+
'/packs',
5757
);
5858
expect(screen.getByRole('link', { name: 'Terminal' })).toHaveAttribute(
5959
'href',
@@ -67,10 +67,10 @@ describe('Footer public shell', () => {
6767
'href',
6868
'https://github.com/engineeredsoftware/bitcode',
6969
);
70-
expect(screen.getByRole('button', { name: 'Explain Exchange' })).toBeInTheDocument();
70+
expect(screen.getByRole('button', { name: 'Explain Packs' })).toBeInTheDocument();
7171
expect(screen.getByRole('button', { name: 'Explain Terminal' })).toBeInTheDocument();
7272
expect(screen.getByRole('button', { name: 'Explain Docs' })).toBeInTheDocument();
73-
expect(screen.getByText('Public exchange')).toBeInTheDocument();
73+
expect(screen.getByText('Pack activity')).toBeInTheDocument();
7474
expect(screen.getAllByText('Terminal').length).toBeGreaterThan(0);
7575
expect(screen.getByText('Docs hub')).toBeInTheDocument();
7676
expect(screen.getByText('Deposit')).toBeInTheDocument();

‎uapi/tests/navBrand.test.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ describe('NavBrand', () => {
1212
expect(screen.getByText('terminal')).toBeTruthy();
1313
});
1414

15-
it('renders exchange copy for mounted exchange routes', () => {
15+
it('renders packs copy for mounted pack activity routes', () => {
1616
render(<NavBrand surface="network" onClick={() => {}} />);
1717

1818
expect(screen.getByLabelText('Bitcode logo')).toBeTruthy();
1919
expect(screen.getByText('Bitcode')).toBeTruthy();
20-
expect(screen.getByText('exchange')).toBeTruthy();
20+
expect(screen.getByText('packs')).toBeTruthy();
2121
});
2222

2323
it('renders homepage copy for the public homepage', () => {

‎uapi/tests/terminalTransactionReadModel.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ describe('terminal transaction read model', () => {
144144
expect(model.route.href).toContain('transactionDetail=proofs');
145145
expect(model.route.href).toContain('provider=github');
146146
expect(model.route.href).not.toContain('runId=legacy-run');
147-
expect(model.route.exchangeHref).toContain('/exchange?');
147+
expect(model.route.exchangeHref).toContain('/packs?');
148148
expect(model.route.exchangeHref).toContain('transactionId=tx-read-1');
149149
expect(model.route.exchangeHref).toContain('transactionDetail=proofs');
150150
expect(model.route.exchangeHref).toContain('provider=github');

0 commit comments

Comments
 (0)