Skip to content

Commit d02e47d

Browse files
V48 (specification-only): Record deposit modularization completion posture
Update NOTES and parity for DepositPageClient orchestration (~677 LOC) and the nine deposit hooks after lifecycle extraction; note remaining density is in single-purpose UI units, not god clients.
1 parent 39f9f86 commit d02e47d

2 files changed

Lines changed: 10 additions & 5 deletions

File tree

BITCODE_SPEC_V48_NOTES.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1356,9 +1356,14 @@ Packs experience (thin page client):
13561356
| Activity detail aside | `PacksActivityDetail/` |
13571357
| Payload types | `packs/models/packs-activity-types.ts` |
13581358

1359-
**Still deposit-touched and thinning:** synthesis completion / adoption /
1360-
dispatch effects still in `DepositPageClient` (~920 LOC after option +
1361-
activity hooks); option cards still nested in `DepositAssetPackOptions`.
1359+
**Deposit experience modularization status:** `DepositPageClient` is
1360+
orchestration (~677 LOC) with models + hooks covering live runs, demand, URL,
1361+
VCS inventory, option actions, activity recording, and synthesis lifecycle.
1362+
Remaining markup density lives in single-purpose units (`DepositAssetPackOptions`
1363+
~749, `DepositSourceSelection` render ~682, aside/obfuscations panels) —
1364+
SRP-valid; further card splits optional. Shared bitcode/pipeline and
1365+
`packages/pipelines/asset-pack` deposit domain files are already package-shaped
1366+
and not page god-clients.
13621367

13631368
**Further landings (same modularization pass):**
13641369

BITCODE_SPEC_V48_PARITY_MATRIX.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ storage readback, wallet/provider receipts, and repository delivery receipts.
6868
| Terminal eradication | No live product imports from `uapi/app/terminal/`; `/terminal` redirect-only or removed; nav/login not Terminal CTAs | closed| product-routes, repository-context, run-data/activity/transactions, readiness, pipelines table, Auxillaries open button relocated; deposits/reads product pages no longer import app/terminal except conversations buildTerminalHref; residual Terminal transitive deps inside relocated panels remain for later | version/v48 workstream |
6969
| BTD journal / operational health naming | Package modules use `journal` and `operational-health` (non-Terminal); temporary Terminal aliases until callers migrate | substantially advanced | `packages/btd/src/journal.ts` + `operational-health.ts` canonical; `terminal-journal` / `terminal-operational-health` shims | version/v48 workstream |
7070
| Package-first utilities | Generalizable pure logic from uapi `lib/` and pure terminal models live in `packages/` or Bitcode models | substantially advanced| Law specified; wallet/cancel/analytics extractions planned Phase 7 | version/v48 workstream |
71-
| God-client modularization | Deposit/Read/Packs page clients thin; logic in experience subcomponents/hooks/models (SRP) | substantially advanced | Packs shell ~187 LOC with portfolio/master/detail units; Deposit models/hooks extracted (`deposit-activity-ledger`, settled demand, live runs, URL nav); `DepositPageClient` ~1.2k (handlers remain); `DepositSourceSelection` inventory effects remain; Read still pending | version/v48 workstream |
72-
| Deposit modular units | Pure deposit projections + hooks unit-tested; G3-14 source map lists modular paths | substantially advanced | Models + hooks + named units under `uapi/components/deposits/`; jest allowlist includes `depositActivityLedger`, `depositSourceCriticality`, `depositRunStatus` | version/v48 workstream |
71+
| God-client modularization | Deposit/Read/Packs page clients thin; logic in experience subcomponents/hooks/models (SRP) | substantially advanced | Packs shell ~187 LOC; DepositPageClient ~677 LOC orchestration with models + hooks (live runs, demand, URL, VCS inventory, option actions, activity recording, synthesis lifecycle); DepositSourceSelection ~682 render + VCS hook; Read still pending | version/v48 workstream |
72+
| Deposit modular units | Pure deposit projections + hooks unit-tested; G3-14 source map lists modular paths | substantially advanced | Models + 9 page-client hooks + VCS hook + named UI units under `uapi/components/deposits/`; jest allowlist includes `depositActivityLedger`, `depositSourceCriticality`, `depositRunStatus` | version/v48 workstream |
7373

7474
## Grouped closure gates
7575

0 commit comments

Comments
 (0)