Skip to content

Commit cfeb279

Browse files
V48 (specification-implementation): Modularize reads experience page clients and models
Split oversized Reads clients and models into named component units, co-located hooks, and pure model builders per BITCODE_SOURCE_LAYOUT. Thin ReadPageClient orchestration; extract pipeline telemetry, route aside, repository field/units, scenario actions/review/list; split read-route-model and enterprise UX types; document entry paths in README and FAMILIARIZATION §7.3.
1 parent 2defb11 commit cfeb279

36 files changed

Lines changed: 4748 additions & 3598 deletions

FAMILIARIZATION.md

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -390,6 +390,25 @@ Shares synthesis pipeline core; **read lens** / neediness finalization continues
390390
in later V48 gates. Workbench panels under `Reads*` + `models/deposit-read-*`
391391
(historical name; deposit+read shared workbench models).
392392

393+
**Reads modularization (entry paths):**
394+
395+
- Page orchestration: `uapi/components/reads/ReadPageClient/ReadPageClient.tsx`
396+
with hooks (`use-read-live-runs`, `use-read-url-navigation`,
397+
`use-read-pipeline-telemetry`, `use-read-session-projections`,
398+
`use-read-activity-recording`, `use-read-route-params`)
399+
- Pipelines master-detail: `ReadsPipelinesSection` + `ReadsPipelineTelemetry`
400+
- Route aside: `ReadsRouteStateAside` + pure rows in `models/read-route-rows.ts`
401+
- Route model facade: `models/read-route-model.ts` (types in
402+
`read-route-session-types.ts`; procurement / fit / settlement builders
403+
co-located siblings)
404+
- Enterprise reading steps: `enterprise-reading-ux-types.ts` +
405+
`enterprise-reading-ux-state.ts`
406+
- Repository supply: `ReadsRepositoryContextPanel` + `use-reads-repository-vcs`
407+
+ field grid / connection / supply / guidance units
408+
- Scenario measurement: `ReadsReadScenarioPanel` + `use-read-scenario-actions`
409+
+ fitting review / scenario list units
410+
- Evidence rows: `deposit-read-evidence-*-rows.ts` facades under `models/`
411+
393412
### 7.4 Packs (`/packs`)
394413

395414
Network-scope PackActivity master-detail (ledgerized history).
@@ -427,6 +446,19 @@ utilities). Prefer `/packs` as post-auth landing, not Terminal.
427446
Identity, wallet, GitHub externals, interfaces, organization/treasury panes.
428447
Route: `/auxillaries/[pane]`. Overlays can open from product pages.
429448

449+
| Concern | Location under `uapi/components/auxillaries/` |
450+
| --- | --- |
451+
| Surface shell + step wiring | `AuxillariesSurface/` (`hooks/`, `models/`, dynamic pane imports) |
452+
| Profile | `AuxillariesProfilePane/` + `Profile*Section/`, `OrganizationAuthoritySection/` |
453+
| Wallet / BTD | `AuxillariesWalletPane/` + `WalletBtdPostureSection/`, `AuxillariesWalletConnectionPanel/` |
454+
| Externals / GitHub | `AuxillariesExternalsPane/` + `ExternalsConnectedWorkspace/`, `ExternalsWalletRequiredGate/` |
455+
| Interfaces | `AuxillariesInterfacesPane/` + `InterfaceAdmissionCatalog/` |
456+
| Organization | `organization/OrganizationSettings/` (tab units) + `BTDTreasuryManagement/` |
457+
| Shared chrome | `headers/`, `shared/` (tabs, stat grids, preference cards, workspace sections) |
458+
459+
Layout contract: `uapi/components/auxillaries/README.md` and
460+
`internal-docs/BITCODE_SOURCE_LAYOUT.md`.
461+
430462
### 7.8 Bitcode base
431463

432464
Shared chrome: `Nav`, `AuthProvider`, `ProductRouteShell`, `BitcodePipelinesTable`,

uapi/components/reads/README.md

Lines changed: 47 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,52 @@
66
reads/
77
README.md
88
models/
9-
deposit-read-workbench.ts # stable public re-exports
10-
deposit-read-workbench-types.ts # source revision + workbench types
11-
deposit-read-workbench-snapshot.ts # live shell snapshot builder
12-
deposit-read-workbench-normalize.ts # snapshot → deposit/read/fit view model
13-
deposit-read-evidence-rows.ts # pure evidence/key-value row builders
14-
enterprise-reading-ux-state.ts
15-
read-route-model.ts
9+
deposit-read-workbench.ts # stable public re-exports
10+
deposit-read-workbench-types.ts
11+
deposit-read-workbench-snapshot.ts
12+
deposit-read-workbench-normalize.ts # normalize snapshot → view model
13+
deposit-read-workbench-normalize-helpers.ts
14+
deposit-read-evidence-rows.ts # evidence facade
15+
deposit-read-evidence-row-builders.ts # row-builder facade
16+
deposit-read-evidence-disclosure-rows.ts
17+
deposit-read-evidence-asset-pack-rows.ts
18+
deposit-read-evidence-need-rows.ts
19+
enterprise-reading-ux-types.ts # step catalog + types
20+
enterprise-reading-ux-state.ts # builders + re-exports
21+
read-route-session-types.ts
22+
read-route-helpers.ts
23+
read-procurement-governance.ts
24+
read-fit-measurement-review.ts
25+
read-settlement-rights-delivery.ts
26+
read-route-model.ts # session facade + stage helpers
27+
read-route-rows.ts # session / procurement / authority rows
1628
read-scenarios.ts
1729
read-format.ts
1830
read-workbench-values.ts
1931
ReadPageClient/
20-
ReadPageClient.tsx
21-
hooks/use-read-route-params.ts
32+
ReadPageClient.tsx # thin orchestration
33+
hooks/
34+
use-read-route-params.ts
35+
use-read-live-runs.ts
36+
use-read-url-navigation.ts
37+
use-read-pipeline-telemetry.ts
38+
use-read-session-projections.ts
39+
use-read-activity-recording.ts
40+
ReadsPipelinesSection/
41+
ReadsPipelineTelemetry/
42+
ReadsRouteStateAside/
43+
ReadsPipelinesMaster/
44+
ReadsRepositoryContextPanel/
45+
hooks/use-reads-repository-vcs.ts
46+
ReadsRepositoryFieldGrid/
47+
ReadsRepositoryConnectionUnit/
48+
ReadsRepositorySupplyUnit/
49+
ReadsRepositoryGuidanceUnit/
50+
ReadsReadScenarioPanel/
51+
hooks/use-read-scenario-actions.ts
52+
ReadsReadScenarioFittingReview/
53+
ReadsReadScenarioList/
2254
ReadsDepositReadWorkbench/
23-
ReadsDepositReadWorkbench.tsx # orchestration only
2455
hooks/
2556
use-deposit-read-activity-recording.ts
2657
use-deposit-read-harness.ts
@@ -33,14 +64,16 @@ reads/
3364
ReadsMeasuredReadAdmissionPanel/
3465
ReadsFitWorkbenchPanel/
3566
ReadsEnterpriseReadingSteps/
36-
ReadsRepositoryContextPanel/
37-
ReadsReadScenarioPanel/
38-
ReadsPipelinesMaster/
3967
```
4068

4169
Page shell: `uapi/app/reads/`.
4270

43-
Import Bitcode only. Full filesystem contract: `internal-docs/BITCODE_SOURCE_LAYOUT.md`.
71+
Import Bitcode only (no cross-experience imports for new work). Full filesystem
72+
contract: `internal-docs/BITCODE_SOURCE_LAYOUT.md`.
4473

4574
Stable external import for workbench models remains:
4675
`@/components/reads/models/deposit-read-workbench`.
76+
77+
Stable external import for route model remains:
78+
`@/components/reads/models/read-route-model` (also via deprecated
79+
`@/app/reads/read-route-model` re-export).

0 commit comments

Comments
 (0)